HHH-19444 SQLiteDialect - Fix ViolatedConstraintNameExtractor #10130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbellade
reviewed
May 12, 2025
hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SQLiteDialect.java
Show resolved
Hide resolved
hibernate-community-dialects/src/main/java/org/hibernate/community/dialect/SQLiteDialect.java
Outdated
Show resolved
Hide resolved
See sqlite/sqlite@f9c8ce3 > Standardize the error messages generated by constraint failures to a format of "$TYPE constraint failed: $DETAIL". Also in case [extended result codes](http://sqlite.org/c3ref/extended_result_codes.html) are activated, we need the `& 0xFF`. And as there seems to be no way to tell `extractUsingTemplate` that there is no `templateEnd`, the linefeed is used... See [original](https://github.com/gwenn/sqlite-dialect/blob/c87223460e3335ff4f041e012bd0d22df99fa2af/src/main/java/org/sqlite/hibernate/dialect/SQLiteDialect.java#L244-L253) code and associated [test](https://github.com/gwenn/sqlite-dialect/blob/c87223460e3335ff4f041e012bd0d22df99fa2af/src/test/java/org/hibernate/tutorial/annotations/AnnotationsIllustrationTest.java#L95-L105) for reference.
mbellade
reviewed
May 13, 2025
|
Thanks for your help @mbladel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sqlite/sqlite@f9c8ce3
Also in case extended result codes are activated, we need the
& 0xFF.And as there seems to be no way to tell
extractUsingTemplatethat there is notemplateEnd, the dollar sign is used...See original code and associated test for reference.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19444