Skip to content

use direct access to instvars in AbstractSharedSessionContract #10220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2025
Merged

use direct access to instvars in AbstractSharedSessionContract #10220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2af10ef
use direct access to instvars in AbstractSharedSessionContract
gavinking May 24, 2025
ec4ea11
simplify methods in SessionEventListenerManagerImpl
gavinking May 25, 2025
0eaa87c
add a comment explaining something rather subtle about session closure
gavinking May 25, 2025
e8328c0
add tests for session closure in regular and JPA bootstrap
gavinking May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
230 changes: 92 additions & 138 deletions ...ate-core/src/main/java/org/hibernate/engine/internal/SessionEventListenerManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,232 +48,190 @@ public void addListener(final SessionEventListener... additionalListeners) {

@Override
public void transactionCompletion(boolean successful) {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.transactionCompletion( successful );
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.transactionCompletion( successful );
}
}
}

@Override
public void jdbcConnectionAcquisitionStart() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.jdbcConnectionAcquisitionStart();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.jdbcConnectionAcquisitionStart();
}
}
}

@Override
public void jdbcConnectionAcquisitionEnd() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.jdbcConnectionAcquisitionEnd();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.jdbcConnectionAcquisitionEnd();
}
}
}

@Override
public void jdbcConnectionReleaseStart() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.jdbcConnectionReleaseStart();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.jdbcConnectionReleaseStart();
}
}
}

@Override
public void jdbcConnectionReleaseEnd() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.jdbcConnectionReleaseEnd();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.jdbcConnectionReleaseEnd();
}
}
}

@Override
public void jdbcPrepareStatementStart() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.jdbcPrepareStatementStart();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.jdbcPrepareStatementStart();
}
}
}

@Override
public void jdbcPrepareStatementEnd() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.jdbcPrepareStatementEnd();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.jdbcPrepareStatementEnd();
}
}
}

@Override
public void jdbcExecuteStatementStart() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.jdbcExecuteStatementStart();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.jdbcExecuteStatementStart();
}
}
}

@Override
public void jdbcExecuteStatementEnd() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.jdbcExecuteStatementEnd();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.jdbcExecuteStatementEnd();
}
}
}

@Override
public void jdbcExecuteBatchStart() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.jdbcExecuteBatchStart();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.jdbcExecuteBatchStart();
}
}
}

@Override
public void jdbcExecuteBatchEnd() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.jdbcExecuteBatchEnd();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.jdbcExecuteBatchEnd();
}
}
}

@Override
public void cachePutStart() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.cachePutStart();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.cachePutStart();
}
}
}

@Override
public void cachePutEnd() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.cachePutEnd();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.cachePutEnd();
}
}
}

@Override
public void cacheGetStart() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.cacheGetStart();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.cacheGetStart();
}
}
}

@Override
public void cacheGetEnd(boolean hit) {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.cacheGetEnd( hit );
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.cacheGetEnd( hit );
}
}
}

@Override
public void flushStart() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.flushStart();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.flushStart();
}
}
}

@Override
public void flushEnd(int numberOfEntities, int numberOfCollections) {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.flushEnd( numberOfEntities, numberOfCollections );
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.flushEnd( numberOfEntities, numberOfCollections );
}
}
}

@Override
public void prePartialFlushStart() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.prePartialFlushStart();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.prePartialFlushStart();
}
}
}

@Override
public void prePartialFlushEnd() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.prePartialFlushEnd();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.prePartialFlushEnd();
}
}
}

@Override
public void partialFlushStart() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.partialFlushStart();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.partialFlushStart();
}
}
}

@Override
public void partialFlushEnd(int numberOfEntities, int numberOfCollections) {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.partialFlushEnd( numberOfEntities, numberOfCollections );
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.partialFlushEnd( numberOfEntities, numberOfCollections );
}
}
}

Expand All @@ -290,23 +248,19 @@ public void dirtyCalculationStart() {

@Override
public void dirtyCalculationEnd(boolean dirty) {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.dirtyCalculationEnd( dirty );
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.dirtyCalculationEnd( dirty );
}
}
}

@Override
public void end() {
if ( listeners == null ) {
return;
}

for ( SessionEventListener listener : listeners ) {
listener.end();
if ( listeners != null ) {
for ( SessionEventListener listener : listeners ) {
listener.end();
}
}
}
}
Loading