HHH-19491 Improve trace logs to reduce the effort while troubleshooting issues with dirty entities #10244
Conversation
…ng issues with dirty entities
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * a no-op. | ||
| */ | ||
| Object processEntity(Object value, EntityType entityType) throws HibernateException { | ||
| Object processEntity(Object entity, Object value, EntityType entityType) throws HibernateException { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * a no-op. | ||
| */ | ||
| Object processEntity(Object value, EntityType entityType) throws HibernateException { | ||
| Object processEntity(Object entity, Object value, EntityType entityType) throws HibernateException { |
Check notice
Code scanning / CodeQL
Useless parameter Note
|
Honestly I'm not particularly keen on adding more trace-level logging. Not sure how others feel about it. |
|
Hi @gavinking See https://hibernate.atlassian.net/browse/HHH-19495 |
|
Yes I understand that these trace messages helped you find the source of that problem. But when is the next time someone will find them useful? Imagine if we committed new trace-level messages every time we needed them to solve a bug. The source code would be overflowing with them. |
|
Right, I don't have a strong opinion. |
|
Let's see what others think. |
|
I would agree with @gavinking, these logs seem a bit too verbose, especially ones triggered for each property of an entity, and would only be useful in very specific troubleshooting scenarios. If we could improve an existing log with more/better information maybe that would be ok. |
|
Ok. Closing |
3 participants
HHH-19491 Improve trace logs to reduce the effort while troubleshooting issues with dirty entities
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19491