HHH-19500 get rid of layer-breaking operations in UserType #10248
Conversation
- simply delete one which was @Incubating - replace others via deprecation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| default JdbcType getJdbcType(TypeConfiguration typeConfiguration) { | ||
| return typeConfiguration.getJdbcTypeRegistry().getDescriptor( getSqlType() ); | ||
| @Deprecated(since = "7.0", forRemoval = true) | ||
| default long getDefaultSqlLength(Dialect dialect, JdbcType jdbcType) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| default JdbcType getJdbcType(TypeConfiguration typeConfiguration) { | ||
| return typeConfiguration.getJdbcTypeRegistry().getDescriptor( getSqlType() ); | ||
| @Deprecated(since = "7.0", forRemoval = true) | ||
| default long getDefaultSqlLength(Dialect dialect, JdbcType jdbcType) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * Use {@link #getDefaultSqlPrecision()} | ||
| */ | ||
| @Deprecated(since = "7.0", forRemoval = true) | ||
| default int getDefaultSqlPrecision(Dialect dialect, JdbcType jdbcType) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * Use {@link #getDefaultSqlPrecision()} | ||
| */ | ||
| @Deprecated(since = "7.0", forRemoval = true) | ||
| default int getDefaultSqlPrecision(Dialect dialect, JdbcType jdbcType) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * Use {@link #getDefaultSqlScale()} | ||
| */ | ||
| @Deprecated(since = "7.0", forRemoval = true) | ||
| default int getDefaultSqlScale(Dialect dialect, JdbcType jdbcType) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * Use {@link #getDefaultSqlScale()} | ||
| */ | ||
| @Deprecated(since = "7.0", forRemoval = true) | ||
| default int getDefaultSqlScale(Dialect dialect, JdbcType jdbcType) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
gavinking
force-pushed
the
HHH-19500
branch
3 times, most recently
from
c6960ff to
9f74edb
Compare
- getValueConverter() to return JPA AttributeConverter since this is a much less technical interface and is easier for user to implement - had to fix a problem with embeddable discriminators manifesting in JsonHelper and StructHelper and took the opportunity to clean up use of generic types - now probably need efficient impls of isInstance()
|
Love these tech-debt-reducing updates! |
2 participants
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19500