Skip to content

Implement equals() and hashCode() for NativeQueryConstructorTransformer #10306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Implement equals() and hashCode() for NativeQueryConstructorTransformer #10306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f12f31f
implement equals() / hashCode() for NativeQueryConstructorTransformer
gavinking Jun 11, 2025
02b381d
add extra item of info to comment
gavinking Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rnate-core/src/main/java/org/hibernate/exception/internal/SQLStateConversionDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public SQLStateConversionDelegate(ConversionContext conversionContext) {
return new JDBCConnectionException( message, sqlException, sql );
case
"21", // "cardinality violation"
"22": // "data exception" (22001 is string too long)
"22": // "data exception" (22001 is string too long; 22003 is numeric value out of range)
return new DataException( message, sqlException, sql );
case
"28": // "authentication failure"
Expand Down
14 changes: 13 additions & 1 deletion hibernate-core/src/main/java/org/hibernate/jpa/spi/NativeQueryConstructorTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
public class NativeQueryConstructorTransformer<T> implements TupleTransformer<T> {

private final Class<T> resultClass;
private Constructor<T> constructor;
private transient Constructor<T> constructor;

private Constructor<T> constructor(Object[] elements) {
if ( constructor == null ) {
Expand Down Expand Up @@ -75,4 +75,16 @@ public T transformTuple(Object[] tuple, String[] aliases) {
throw new InstantiationException( "Cannot instantiate query result type", resultClass, e );
}
}

@Override
public boolean equals(Object obj) {
return obj instanceof NativeQueryConstructorTransformer<?> that
&& this.resultClass == that.resultClass;
// should be safe to ignore the cached constructor here
}

@Override
public int hashCode() {
return resultClass.hashCode();
}
}