Skip to content

Conversation

@cigaly
Copy link
Contributor

@cigaly cigaly commented Jun 17, 2025

In case that someone may find this useful ... foiund this branch while cleaning my local branches. If not, closing the branch is very easy

Jira issue HHH-18708

Function from issue title has been implemented in a way almost identical how existing ordinal/( function is implemented.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@gavinking
Copy link
Member

Thanks Cedomir!

Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinking gavinking merged commit 7f0f0be into hibernate:main Jun 18, 2025
23 of 24 checks passed
@gavinking
Copy link
Member

Thanks man!

@cigaly
Copy link
Contributor Author

cigaly commented Jun 18, 2025

Thanks man!

You're welcome!

@mbellade
Copy link
Member

Great job @cigaly, it would be nice to add this to the user guide like for ordinal() (I see you left tags in your test, maybe you wanted to but forgot to add to the asciidoc).

@gavinking
Copy link
Member

@mbellade I already took care of that.

@mbellade
Copy link
Member

Yep I just saw your pr #10368, ty @gavinking and @cigaly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants