Skip to content

Conversation

@gavinking
Copy link
Member

@gavinking gavinking commented Jun 27, 2025

@DavideD note that this change breaks Hibernate Reactive

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19523

…elessSession

note that this change breaks Hibernate Reactive
@DavideD
Copy link
Member

DavideD commented Jun 27, 2025

ACK

@DavideD
Copy link
Member

DavideD commented Jun 27, 2025

No test case?

@gavinking
Copy link
Member Author

No test case?

Hold yr horses, I'm working on it.

@gavinking gavinking merged commit f14a23e into hibernate:main Jun 27, 2025
25 of 26 checks passed
@DavideD
Copy link
Member

DavideD commented Jun 27, 2025

Cool, thanks

@yrodiere
Copy link
Member

yrodiere commented Jul 1, 2025

@DavideD I will need to backport this one to 7.0... Could you please work on a patch to adjust Reactive accordingly in 3.0?

@gavinking
Copy link
Member Author

gavinking commented Jul 1, 2025

I will need to backport this one to 7.0... Could you please work on a patch to adjust Reactive accordingly in 3.0?

Oooh I don't like this idea. This ties micro versions of Reactive to micro versions of ORM.

@yrodiere
Copy link
Member

yrodiere commented Jul 1, 2025

I will need to backport this one to 7.0... Could you please work on a patch to adjust Reactive accordingly in 3.0?

Oooh I don't like this idea. This ties micro versions of Reactive to micro versions of ORM.

I hate it as much as you do. Do you think this can be fixed another way?

@gavinking
Copy link
Member Author

Do you think this can be fixed another way?

You could just disable the code in StatelessSessionImpl which raises those events. Since, quite clearly, they're not doing any useful work.

@yrodiere
Copy link
Member

yrodiere commented Jul 1, 2025

Do you think this can be fixed another way?

You could just disable the code in StatelessSessionImpl which raises those events. Since, quite clearly, they're not doing any useful work.

Fine by me. @mbellade , since you were already looking into this... could you please try it? And add the test from this PR, or another one if necessary?

I'd do it, but I'm fighting with website config.

@mbellade
Copy link
Member

mbellade commented Jul 3, 2025

Here's the pr: #10465.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants