More Informix #10430
More Informix #10430
Conversation
not doing so caused the test to fail on Informix (and possibly other dbs)
so that one failure doesn't drag everything down with it
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
it comes wrapped in a containing exception with diff error code
this caused a failure on Informix
apparently we do need to use getDual() when there is a 'where' clause but no 'from' clause
and skip the test also on Informix
add a new DialectFeatureCheck
| } | ||
| else { | ||
| if ( source instanceof QueryLiteral<?> literal && literal.getLiteralValue() == null ) { | ||
| literal.setInCast(true); |
There was a problem hiding this comment.
You're making QueryLiteral mutable and change its state as part of rendering here which is a bit dirty IMO. Can you explain why you need this?`
There was a problem hiding this comment.
There is code which wraps literals in a cast(). But if the literal is already the argument of an explicit cast() function, we don't need to do that.
We could detect this situation earlier in the lifecycle, for example in SQB, but then we would have to pass that info all along the different trees, which is a PITA, but doable, obviously.
Ideally, the visitor itself would record this sort of state. But without knowing the tree structure very well, I would not know how to do that in a correct-enough way.
2 participants
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.