- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 3.7k
 
[7.0] HHH-19464 storing a binary data into blob on oracle cutting off its content #10431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            3 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            117 changes: 117 additions & 0 deletions
          
          117 
        
  hibernate-core/src/test/java/org/hibernate/orm/test/lob/InflaterInputStreamBlobTest.java
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright Red Hat Inc. and Hibernate Authors | ||
| */ | ||
| package org.hibernate.orm.test.lob; | ||
| 
     | 
||
| import jakarta.persistence.Entity; | ||
| import jakarta.persistence.Id; | ||
| import jakarta.persistence.Lob; | ||
| import org.hibernate.engine.jdbc.env.internal.NonContextualLobCreator; | ||
| import org.hibernate.testing.orm.junit.DomainModel; | ||
| import org.hibernate.testing.orm.junit.JiraKey; | ||
| import org.hibernate.testing.orm.junit.SessionFactory; | ||
| import org.hibernate.testing.orm.junit.SessionFactoryScope; | ||
| import org.junit.jupiter.api.Test; | ||
| 
     | 
||
| import java.io.ByteArrayInputStream; | ||
| import java.io.ByteArrayOutputStream; | ||
| import java.io.IOException; | ||
| import java.io.InputStream; | ||
| import java.sql.Blob; | ||
| import java.sql.SQLException; | ||
| import java.util.Random; | ||
| import java.util.zip.GZIPInputStream; | ||
| import java.util.zip.GZIPOutputStream; | ||
| 
     | 
||
| import static org.junit.jupiter.api.Assertions.assertArrayEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| 
     | 
||
| @DomainModel(annotatedClasses = InflaterInputStreamBlobTest.TestEntity.class) | ||
| @SessionFactory | ||
| @JiraKey("HHH-19464") | ||
| class InflaterInputStreamBlobTest { | ||
| 
     | 
||
| private static final int RANDOM_SIZE = 32000; | ||
| 
     | 
||
| @Test | ||
| void hibernate_blob_streaming(SessionFactoryScope scope) throws Exception { | ||
| final var randomBytes = getRandomBytes(); | ||
| final var outputStream = new ByteArrayOutputStream(); | ||
| try (var zipOutputStream = new GZIPOutputStream( outputStream )) { | ||
| zipOutputStream.write( randomBytes ); | ||
| } | ||
| 
     | 
||
| long size = randomBytes.length; | ||
| scope.inTransaction( entityManager -> { | ||
| try { | ||
| InputStream is = new GZIPInputStream( new ByteArrayInputStream( outputStream.toByteArray() ) ); | ||
| Blob blob = NonContextualLobCreator.INSTANCE.wrap( | ||
| NonContextualLobCreator.INSTANCE.createBlob( is, size ) | ||
| ); | ||
| TestEntity e = new TestEntity(); | ||
| e.setId( 1L ); | ||
| e.setData( blob ); | ||
| 
     | 
||
| entityManager.persist( e ); | ||
| } | ||
| catch (IOException e) { | ||
| throw new RuntimeException( e ); | ||
| } | ||
| } | ||
| ); | ||
| 
     | 
||
| scope.inStatelessSession( session -> { | ||
| final var entity = session.get( TestEntity.class, 1L ); | ||
| try { | ||
| final var blob = entity.getData(); | ||
| assertEquals( size, blob.length() ); | ||
| assertArrayEquals( randomBytes, blob.getBytes( 1L, (int) blob.length() ) ); | ||
| } | ||
| catch (SQLException e) { | ||
| throw new RuntimeException( e ); | ||
| } | ||
| } ); | ||
| } | ||
| 
     | 
||
| private static byte[] getRandomBytes() { | ||
| final var bytes = new byte[RANDOM_SIZE]; | ||
| new Random().nextBytes( bytes ); | ||
| return bytes; | ||
| } | ||
| 
     | 
||
| @Entity | ||
| public static class TestEntity { | ||
| 
     | 
||
| @Id | ||
| Long id; | ||
| 
     | 
||
| @Lob | ||
| Blob data; | ||
| 
     | 
||
| public Long getId() { | ||
| return id; | ||
| } | ||
| 
     | 
||
| public void setId(Long id) { | ||
| this.id = id; | ||
| } | ||
| 
     | 
||
| public Blob getData() { | ||
| return data; | ||
| } | ||
| 
     | 
||
| public InputStream getInputStream() { | ||
| try { | ||
| return data.getBinaryStream(); | ||
| } | ||
| catch (SQLException e) { | ||
| throw new IllegalArgumentException( "Could not obtain requested input stream", e ); | ||
| } | ||
| } | ||
| 
     | 
||
| public void setData(Blob data) { | ||
| this.data = data; | ||
| } | ||
| } | ||
| } | ||
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Check warning
Code scanning / CodeQL
Random used only once Warning test