Skip to content

try enabling these tests on Db2 🤞 #10460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025
Merged

try enabling these tests on Db2 🤞 #10460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions hibernate-core/src/test/java/org/hibernate/orm/test/datasource/DataSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
import org.hibernate.testing.orm.junit.Jpa;
import org.hibernate.testing.orm.junit.Setting;
import org.hibernate.testing.orm.junit.SkipForDialect;
import org.jboss.logging.Logger;
import org.junit.jupiter.api.Test;

Expand All @@ -29,7 +28,6 @@
@Jpa(annotatedClasses = DataSourceTest.TestEntity.class,
integrationSettings = @Setting(name = JdbcSettings.CONNECTION_PROVIDER,
value = "org.hibernate.orm.test.datasource.TestDataSourceConnectionProvider"))
@SkipForDialect(dialectClass = DB2Dialect.class)
public class DataSourceTest {
@Test
void test(EntityManagerFactoryScope scope) {
Expand All @@ -39,6 +37,7 @@ void test(EntityManagerFactoryScope scope) {
LogInspectionHelper.clearAllListeners( ConnectionInfoLogger.INSTANCE );
Dialect dialect = scope.getDialect();
assertTrue( dialect instanceof OracleDialect od && od.isAutonomous()
|| dialect instanceof DB2Dialect
|| dialect instanceof InformixDialect // Informix metadata does not include the URL
|| listener.seen );
}
Expand Down
4 changes: 1 addition & 3 deletions ...rc/test/java/org/hibernate/orm/test/mapping/converted/converter/AndNationalizedTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@
import org.hibernate.boot.registry.StandardServiceRegistry;
import org.hibernate.boot.registry.StandardServiceRegistryBuilder;
import org.hibernate.boot.spi.MetadataImplementor;
import org.hibernate.dialect.DB2Dialect;
import org.hibernate.dialect.Dialect;
import org.hibernate.mapping.PersistentClass;

import org.hibernate.testing.SkipForDialect;
import org.hibernate.testing.orm.junit.JiraKey;
import org.hibernate.testing.junit4.BaseUnitTestCase;
import org.hibernate.testing.util.ServiceRegistryUtil;
Expand All @@ -33,7 +31,7 @@
*
* @author Steve Ebersole
*/
@SkipForDialect(value = DB2Dialect.class, comment = "DB2 jdbc driver doesn't support setNString")
//@SkipForDialect(value = DB2Dialect.class, comment = "DB2 jdbc driver doesn't support setNString")
public class AndNationalizedTests extends BaseUnitTestCase {
@Test
@JiraKey( value = "HHH-9599")
Expand Down
2 changes: 1 addition & 1 deletion ...-core/src/test/java/org/hibernate/orm/test/query/criteria/CriteriaWindowFunctionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ public void testRank(SessionFactoryScope scope) {
}

@Test
@SkipForDialect(dialectClass = DB2Dialect.class, majorVersion = 10, reason = "No support for percent_rank and cume_dist functions")
// @SkipForDialect(dialectClass = DB2Dialect.class, majorVersion = 10, reason = "No support for percent_rank and cume_dist functions")
@SkipForDialect(dialectClass = AltibaseDialect.class, reason = "No support for percent_rank and cume_dist functions with over clause")
public void testReusableWindow(SessionFactoryScope scope) {
scope.inTransaction(
Expand Down