Skip to content

log that JDBC batching is enabled at startup #10506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

log that JDBC batching is enabled at startup #10506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/JdbcBatchLogging.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ public interface JdbcBatchLogging extends BasicLogger {
Logger BATCH_LOGGER = Logger.getLogger( NAME );
JdbcBatchLogging BATCH_MESSAGE_LOGGER = Logger.getMessageLogger( MethodHandles.lookup(), JdbcBatchLogging.class, NAME );

@LogMessage(level = INFO)
@Message(id=100501, value = "Automatic JDBC statement batching enabled (maximum batch size %s)")
void batchingEnabled(int batchSize);

@LogMessage(level = WARN)
@Message(id = 100502, value = "Unable to release batch statement")
void unableToReleaseBatchStatement();
Expand Down
18 changes: 8 additions & 10 deletions hibernate-core/src/main/java/org/hibernate/engine/jdbc/batch/internal/BatchBuilderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import static java.util.Collections.emptyList;
import static org.hibernate.engine.jdbc.batch.JdbcBatchLogging.BATCH_LOGGER;
import static org.hibernate.engine.jdbc.batch.JdbcBatchLogging.BATCH_MESSAGE_LOGGER;

/**
* A builder for {@link Batch} instances.
Expand All @@ -36,13 +37,10 @@ public class BatchBuilderImpl implements BatchBuilder {
* on {@link #buildBatch}
*/
public BatchBuilderImpl(int globalBatchSize) {
if ( BATCH_LOGGER.isTraceEnabled() ) {
BATCH_LOGGER.tracef(
"Using standard BatchBuilder (%s)",
globalBatchSize
);
if ( globalBatchSize > 1 ) {
BATCH_MESSAGE_LOGGER.batchingEnabled( globalBatchSize );
}

BATCH_LOGGER.trace( "Using standard BatchBuilder");
this.globalBatchSize = globalBatchSize;
}

Expand All @@ -56,11 +54,11 @@ public Batch buildBatch(
Integer explicitBatchSize,
Supplier<PreparedStatementGroup> statementGroupSupplier,
JdbcCoordinator jdbcCoordinator) {
final int batchSize = explicitBatchSize == null
? globalBatchSize
: explicitBatchSize;
final int batchSize =
explicitBatchSize == null
? globalBatchSize
: explicitBatchSize;
assert batchSize > 1;

return new BatchImpl( key, statementGroupSupplier.get(), batchSize, jdbcCoordinator );
}

Expand Down