Skip to content

Make FormulaWithPartitionByTest deterministic and enable partition by… #10548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

Make FormulaWithPartitionByTest deterministic and enable partition by… #10548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ate-community-dialects/src/main/java/org/hibernate/community/dialect/H2LegacyDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,11 @@ public String getCaseInsensitiveLike() {
}
}

@Override
public boolean supportsPartitionBy() {
return getVersion().isSameOrAfter( 1, 4, 200 );
}

@Override
public boolean supportsCaseInsensitiveLike() {
return getVersion().isSameOrAfter( 1, 4, 194 );
Expand Down
5 changes: 5 additions & 0 deletions hibernate-core/src/main/java/org/hibernate/dialect/H2Dialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,6 +1075,11 @@ public boolean supportsCaseInsensitiveLike(){
return true;
}

@Override
public boolean supportsPartitionBy() {
return true;
}

@Override
public boolean supportsBindingNullSqlTypeForSetNull() {
return true;
Expand Down
3 changes: 2 additions & 1 deletion ...core/src/test/java/org/hibernate/orm/test/mapping/formula/FormulaWithPartitionByTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ void tearDown(SessionFactoryScope scope) {
public static class DisplayItem implements Serializable {

@Id
@Column(name = "DISPLAY_ITEM_ID")
private Integer id;

@Column(name = "DISCOUNT_CODE")
Expand All @@ -90,7 +91,7 @@ public static class DisplayItem implements Serializable {
@Column(name = "DISCOUNT_VALUE")
private Double discountValue;

@Formula("ROW_NUMBER() OVER( PARTITION BY DISCOUNT_CODE ORDER BY SIGN(DISCOUNT_VALUE) DESC )")
@Formula("ROW_NUMBER() OVER(PARTITION BY DISCOUNT_CODE ORDER BY DISPLAY_ITEM_ID)")
private Integer itemsByCode;

public Integer getId() {
Expand Down
Loading