modernize some code in o.h.query.sqm.produce.function #10561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...te-core/src/main/java/org/hibernate/query/sqm/produce/function/internal/PatternRenderer.java
Fixed
Show fixed
Hide fixed
gavinking
force-pushed
the
function-stuff
branch
from
f21a5d7 to
93c6242
Compare
pizzi80
reviewed
Jul 17, 2025
| @Override | ||
| public String getSignature() { | ||
| StringBuilder sig = new StringBuilder("("); | ||
| final StringBuilder sig = new StringBuilder("("); |
There was a problem hiding this comment.
If the expected computed String is expected to be quite long, it could be better to initialize all the StringBuilder in this class with an initial capacity large enough to contain the average case ... ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.