HHH-16253 - Schema Validation Failure With Audited (N)Clob Column

[ZIRAKrezovic]

https://hibernate.atlassian.net/browse/HHH-16253

Mentioned change fixes the long-standing issue linked above.

It is my first contribution to Hibernate project. I am unable to find a good place where to include the required test as described in contributor guidelines. I have not found any tests related to HBM XML in hibernate-core. I could add the test in hibernate-envers, similar to Enum test. I'd just like your feedback first to check if this is the right approach. Kindly thank you.

I'd appreciate any feedback before I submit the pull request for remaining branches (it appears main, 7.0, 6.6 and 6.2 are maintained - please correct me if I'm wrong).

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

[mbellade]

Hello @ZIRAKrezovic, thank you for your contribution.

I am unable to find a good place where to include the required test as described in contributor guidelines. I have not found any tests related to HBM XML in hibernate-core. I could add the test in hibernate-envers, similar to Enum test.

Yes, this is definitely the right approach. The Jira issue's reproducer uses annotations to define an hibernate-envers audited entity, that's the only thing we need in the test. The hbm.xml mapping is generated by envers under the hood, so there's no need to test it directly.

I'd appreciate any feedback before I submit the pull request for remaining branches

We would ask you to always submit changes to the main branch. The Hibernate team will then decide which fixes are worth back-porting to previous maintenance versions.

[mbellade]

Superseded by #10607