Skip to content

Conversation

beikov
Copy link
Member

@beikov beikov commented Jul 23, 2025

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19649
https://hibernate.atlassian.net/browse/HHH-18311
https://hibernate.atlassian.net/browse/HHH-19521

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jul 23, 2025

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@beikov beikov changed the title HHH-18311 Allow constructing SqmMultiTableInsertStrategy/SqmMultiTabl… HHH-18311 Allow constructing SqmMultiTableInsertStrategy/SqmMultiTableMutationStrategy with EntityDomainType and MappingModelCreationProcess Jul 23, 2025
@beikov beikov force-pushed the HHH-18311 branch 3 times, most recently from 4d3a0be to faad336 Compare July 23, 2025 11:36
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

I couldn't look at the full implementation, but since it'll apparently well tested, I'm not too concerned. I just have a doubt about the precedence of get*Strategy vs. resolve*Strategy... See comment below.

@beikov beikov force-pushed the HHH-18311 branch 7 times, most recently from f0818fd to af9453e Compare July 25, 2025 15:57
consumer.accept( prefix, basicModelPart );
}
}
else if ( modelPart instanceof EntityValuedModelPart entityPart ) {

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'EntityValuedModelPart entityPart' is never read.
idName = "id";
}
final List<CteColumn> columns = new ArrayList<>( persistentClass.getIdentifier().getColumnSpan() );
final Metadata metadata = persistentClass.getIdentifier().getBuildingContext().getMetadataCollector();

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'Metadata metadata' is never read.
@beikov beikov merged commit c0cb619 into hibernate:main Jul 28, 2025
26 checks passed
@beikov beikov deleted the HHH-18311 branch July 28, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants