Skip to content

HHH-19644 - Enforce usage of SharedDriverManagerConnectionProviderImpl connection pool for hibernate-envers tests #10618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

HHH-19644 - Enforce usage of SharedDriverManagerConnectionProviderImpl connection pool for hibernate-envers tests #10618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hibernate-envers/src/test/resources/hibernate.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@ hibernate.connection.url @jdbc.url@
hibernate.connection.username @jdbc.user@
hibernate.connection.password @jdbc.pass@
hibernate.connection.init_sql @connection.init_sql@
hibernate.connection.autocommit false
hibernate.connection.initial_pool_size 0

hibernate.connection.pool_size 2
hibernate.connection.pool_size 5

hibernate.show_sql false

Expand Down
3 changes: 2 additions & 1 deletion ...rnate-testing/src/main/java/org/hibernate/testing/jta/JtaAwareConnectionProviderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
import org.hibernate.service.spi.ServiceRegistryAwareService;
import org.hibernate.service.spi.ServiceRegistryImplementor;
import org.hibernate.service.spi.Stoppable;
import org.hibernate.testing.jdbc.SharedDriverManagerConnectionProviderImpl;

/**
* A {@link ConnectionProvider} implementation intended for testing Hibernate/JTA interaction. In that limited scope we
Expand All @@ -75,7 +76,7 @@ public class JtaAwareConnectionProviderImpl implements ConnectionProvider, Confi
ServiceRegistryAwareService {
private static final String CONNECTION_KEY = "_database_connection";

private final DriverManagerConnectionProviderImpl delegate = new DriverManagerConnectionProviderImpl();
private final DriverManagerConnectionProviderImpl delegate = SharedDriverManagerConnectionProviderImpl.getInstance();

private final List<Connection> nonEnlistedConnections = new ArrayList<>();

Expand Down
Loading