HHH-19638: Document the Ant enhancement task in User Guide tooling section #10622
Conversation
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
There was a problem hiding this comment.
This is just the testing. I'll leave that to you as I have no knowledge of integration testing Ant tasks inside JUnit - I'll trust your judgement there.
Were you planning on a second PR for the User Guide changes? Just not sure if I should apply this and look for a second, or wait for more commits.
| @@ -8,6 +8,6 @@ plugins { | |||
| description = 'Annotation Processor to generate JPA 2 static metamodel classes' | |||
|
|
|||
| dependencies { | |||
| compileOnly libs.ant | |||
| implementation libs.ant | |||
There was a problem hiding this comment.
This affects the user's build in terms of Ant version though, right? I forget the impact, if any, that might have. Just a question.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private boolean methodIsPresentInClass(String methodName, String className) throws Exception { | ||
| Class<?> classToCheck = getTestClassLoader().loadClass( className ); | ||
| try { | ||
| Object m = classToCheck.getMethod( methodName, new Class[] {} ); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
|
|
||
| private void copyJavFiles() throws Exception { | ||
| File srcDir = new File(projectDir, "src"); | ||
| srcDir.mkdir(); |
Check notice
Code scanning / CodeQL
Ignored error status of call Note test
…ction - Create a test for 'org.hibernate.tool.enhance.EnhancementTask' that covers all the configuration settings (except for 'failOnError') - Describe how to add the task definition to your Ant build, with minimal example - Add a description and short example for each of the configuration attributes and/or elements
|
@sebersole I have added the documentation to the PR. Also, I rolled back the |
More I was asking. But thanks for changing it :) |
Create a test for 'org.hibernate.tool.enhance.EnhancementTask' that covers all the configuration settings
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19638