HHH-19660 - Deprecate enhancement support for automatic association management #10645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebersole
reviewed
Jul 29, 2025
Comment on lines
99
to
100
| Bytecode-enhanced bi-directional association management has been deprecated as of Hibernate v7.1, and will be removed in a future release. Users are encouraged to move away from this functionality and instead adopt | ||
| correct Java usage as outlined in the <<BytecodeEnhancement-dirty-tracking-bidirectional-correct-usage-example, example>> above. |
There was a problem hiding this comment.
I'd prefer to align this wording with your other PR. Something like -
Suggested change
| Bytecode-enhanced bi-directional association management has been deprecated as of Hibernate v7.1, and will be removed in a future release. Users are encouraged to move away from this functionality and instead adopt | |
| correct Java usage as outlined in the <<BytecodeEnhancement-dirty-tracking-bidirectional-correct-usage-example, example>> above. | |
| Hibernate's bi-directional association management bytecode enhancement feature has been deprecated. Users should instead manage both sides of such associations directly. |
We should also clean up uses of "bi-directional" which is actually a word itself: bidirectional. If you want to do that as part of this PR, great. If not, we can just add it as a follow-up. I only see one pre-existing use of that semi-misspelling and it is in this file.
Yes, yes, "pre-existing" may also be written without the hyphen but the hyphenated form is the more formal form ;)
There was a problem hiding this comment.
Well, 2 uses really, but in the same sentence :D
There was a problem hiding this comment.
Exceptions in languages ... 😢 there for the sole purpose of pissing people off ... 🙈 😆
sebersole
reviewed
Jul 29, 2025
…anagement Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
jrenaat
force-pushed
the
HHH-19660_deprecate_auto-assoc-management
branch
from
b6b4507 to
c3740aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19660