-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19660 - Deprecate enhancement support for automatic association management #10645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-19660 - Deprecate enhancement support for automatic association management #10645
Conversation
| Bytecode-enhanced bi-directional association management has been deprecated as of Hibernate v7.1, and will be removed in a future release. Users are encouraged to move away from this functionality and instead adopt | ||
| correct Java usage as outlined in the <<BytecodeEnhancement-dirty-tracking-bidirectional-correct-usage-example, example>> above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to align this wording with your other PR. Something like -
| Bytecode-enhanced bi-directional association management has been deprecated as of Hibernate v7.1, and will be removed in a future release. Users are encouraged to move away from this functionality and instead adopt | |
| correct Java usage as outlined in the <<BytecodeEnhancement-dirty-tracking-bidirectional-correct-usage-example, example>> above. | |
| Hibernate's bi-directional association management bytecode enhancement feature has been deprecated. Users should instead manage both sides of such associations directly. |
We should also clean up uses of "bi-directional" which is actually a word itself: bidirectional. If you want to do that as part of this PR, great. If not, we can just add it as a follow-up. I only see one pre-existing use of that semi-misspelling and it is in this file.
Yes, yes, "pre-existing" may also be written without the hyphen but the hyphenated form is the more formal form ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, 2 uses really, but in the same sentence :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exceptions in languages ... 😢 there for the sole purpose of pissing people off ... 🙈 😆
sebersole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another minor suggestion. Otherwise +1
…anagement Signed-off-by: Jan Schatteman <[email protected]>
Signed-off-by: Jan Schatteman <[email protected]>
b6b4507 to
c3740aa
Compare
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19660