HHH-19668 Reduce size of collections held in ParameterInterpretationImpl before storing them in the cache #10670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpl before storing them in the cache Instances of ParameterInterpretationImpl are being held in the interpretation cache for native queries. We had reports of these elements having a substantial impact on memory consumption. A simple improvement is to ensure the collections being held on by the container object are minimized; some more substantial improvements could also be investigated but I’ll leave those for another time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instances of ParameterInterpretationImpl are being held in the interpretation cache for native queries. We had reports of these elements having a substantial impact on memory consumption.
A simple improvement is to ensure the collections being held on by the container object are minimized; some more substantial improvements could also be investigated but I’ll leave those for another time.
https://hibernate.atlassian.net/browse/HHH-19668
N.B.
I have decided to not include the test which I used to verify this patch as it's not strictly deterministic and of questionable value to be included in integration tests.
But for future reference, should someone want to play with it here it is:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.