HHH-19015 - Deprecate Session#byId in favor of FindOptions

[jrenaat]

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

https://hibernate.atlassian.net/browse/HHH-19015

[sebersole]

I think adding the deprecations to 7.1 is fine.
Made suggestions to apply that.

[gavinking]

Does it make sense to deprecate the method without also deprecating IdentifierLoadAccess?

[sebersole]

Well, at least initially it makes the most sense (simplicity) to simply keep using that infrastructure internally. So for now, I'd say no. After I get the #find overloads correct we could look into converting IdentifierLoadAccess uses to just use FindOptions directly. But for now, I say no

[sebersole]

Well, actually... the interface, yeah I think that does make sense

[sebersole]

@DavideD According to the note on IdentifierLoadAccessImpl, Reactive extends all of this so this deprecation will affect you I think.

[DavideD]

Thanks, I've seen it. I don't remember exactly how we use it, but it should be fine