Skip to content

some cleanups around property accessors #10687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2025
Merged

some cleanups around property accessors #10687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cbe910
some cleanups around property accessors
gavinking Aug 2, 2025
2bfa861
fix spelling "updateable" -> "updatable"
gavinking Aug 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hibernate-core/src/main/java/org/hibernate/boot/jaxb/hbm/transform/ColumnDefaults.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ interface ColumnDefaults {

Boolean isInsertable();

Boolean isUpdateable();
Boolean isUpdatable();
}
2 changes: 1 addition & 1 deletion ...ate-core/src/main/java/org/hibernate/boot/jaxb/hbm/transform/ColumnDefaultsBasicImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public Boolean isInsertable() {
}

@Override
public Boolean isUpdateable() {
public Boolean isUpdatable() {
return Boolean.TRUE;
}
}
2 changes: 1 addition & 1 deletion ...java/org/hibernate/boot/jaxb/hbm/transform/ColumnDefaultsInsertableNonUpdateableImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public Boolean isInsertable() {
}

@Override
public Boolean isUpdateable() {
public Boolean isUpdatable() {
return false;
}
}
4 changes: 2 additions & 2 deletions ...nate-core/src/main/java/org/hibernate/boot/jaxb/hbm/transform/ColumnDefaultsProperty.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ public Boolean isInsertable() {
}

@Override
public Boolean isUpdateable() {
return property.isUpdateable();
public Boolean isUpdatable() {
return property.isUpdatable();
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions hibernate-core/src/main/java/org/hibernate/boot/jaxb/hbm/transform/HbmXmlTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,7 +1554,7 @@ public Boolean isInsertable() {
}

@Override
public Boolean isUpdateable() {
public Boolean isUpdatable() {
return hbmProp.isUpdate();
}
},
Expand Down Expand Up @@ -2797,7 +2797,7 @@ public Boolean isInsertable() {
}

@Override
public Boolean isUpdateable() {
public Boolean isUpdatable() {
return true;
}
},
Expand Down Expand Up @@ -3027,7 +3027,7 @@ public Boolean isInsertable() {
}

@Override
public Boolean isUpdateable() {
public Boolean isUpdatable() {
return true;
}
},
Expand Down
2 changes: 1 addition & 1 deletion ...re/src/main/java/org/hibernate/boot/jaxb/hbm/transform/TargetColumnAdapterJaxbColumn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public TargetColumnAdapterJaxbColumn(JaxbColumnImpl jaxbColumn, ColumnDefaults c
this.jaxbColumn.setNullable( columnDefaults.isNullable() );
this.jaxbColumn.setUnique( columnDefaults.isUnique() );
this.jaxbColumn.setInsertable( columnDefaults.isInsertable() );
this.jaxbColumn.setUpdatable( columnDefaults.isUpdateable() );
this.jaxbColumn.setUpdatable( columnDefaults.isUpdatable() );
}

public JaxbColumnImpl getTargetColumn() {
Expand Down
2 changes: 1 addition & 1 deletion ...rc/main/java/org/hibernate/boot/jaxb/hbm/transform/TargetColumnAdapterJaxbJoinColumn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public TargetColumnAdapterJaxbJoinColumn(JaxbJoinColumnImpl jaxbColumn, ColumnDe
this.jaxbColumn.setNullable( columnDefaults.isNullable() );
this.jaxbColumn.setUnique( columnDefaults.isUnique() );
this.jaxbColumn.setInsertable( columnDefaults.isInsertable() );
this.jaxbColumn.setUpdatable( columnDefaults.isUpdateable() );
this.jaxbColumn.setUpdatable( columnDefaults.isUpdatable() );
}

public JaxbJoinColumnImpl getTargetColumn() {
Expand Down
Loading