Skip to content

Conversation

beikov
Copy link
Member

@beikov beikov commented Aug 7, 2025

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18589

}
}

public static Instant toInstant(Timestamp timestamp) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method DateTimeUtils.toInstant(..) could be confused with overloaded method
toInstant
, since dispatch depends on static types.
@beikov
Copy link
Member Author

beikov commented Aug 11, 2025

This PR also addresses some issues with date conversion between java.time other APIs where the same epoch millisecond might mean different dates for various reasons. It's also worth to mention that the JDBC drivers sometimes rely on a certain epoch millisecond interpretation when passing temporal values, which needs to be accounted for.
I assume that this is the reason for failures in Quarkus: quarkusio/quarkus#37720

@hibernate-github-bot
Copy link

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [271121b]

› This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant