HHH-19703 NativeQueryImpl#addScalar(String, Class) fails when no JavaType is registered #10736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue HHH-19703
In method
org.hibernate.query.sql.internal.NativeQueryImpl#addScalar(java.lang.String, java.lang.Class)
first check ifBasicType is registered. If yes, use it to create result builder (similarily as in
org.hibernate.query.sql.internal.NativeQueryImpl#addScalar(java.lang.String, org.hibernate.metamodel.model.domain.BasicDomainType)`. If not then fall back to existing implementation.Note: Method
org.hibernate.query.sql.internal.NativeQueryImpl#addScalar(int, java.lang.Class<?>)
is not used anywhere. If it is "reserved for future use" or something like that, then it should be fixed. It will fail in exactly opposite case than one with column name - when noJavaType
is registered.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.