Skip to content

Conversation

gavinking
Copy link
Member

@gavinking gavinking commented Aug 12, 2025

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19701

@gavinking gavinking marked this pull request as ready for review August 12, 2025 05:54
@gavinking gavinking merged commit 877e4f0 into hibernate:main Aug 12, 2025
25 of 26 checks passed
@WolfgangHG
Copy link

WolfgangHG commented Aug 12, 2025

@gavinking I think this is not expected - your change adds "if exists" to the default "drop sequence" statement which applies to all databases (though they might not support it). My idea was to implement/override the method getDropSequenceString in https://github.com/hibernate/hibernate-orm/blob/main/hibernate-core/src/main/java/org/hibernate/dialect/sequence/MariaDBSequenceSupport.java

@gavinking
Copy link
Member Author

Ouch, of course, that's totally what I meant to do.

Absolutely crazy that no tests failed.

I guess because most other dialects also override that method.

Anyway, #10744.

@gavinking gavinking mentioned this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants