HHH-19737 - Support Envers with StatelessSession #10753
Conversation
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
sebersole
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private void handlePostUpsert(Object entity, EventSource source) { | ||
| private void handlePostUpsert(Object entity, SharedSessionContractImplementor source) { |
Check notice
Code scanning / CodeQL
Useless parameter
| } | ||
|
|
||
| private void handlePostUpsert(Object entity, EventSource source) { | ||
| private void handlePostUpsert(Object entity, SharedSessionContractImplementor source) { |
Check notice
Code scanning / CodeQL
Useless parameter
| revisionInfoGenerator.saveRevisionData( session, revisionData ); | ||
| } | ||
| } | ||
| else if ( session instanceof StatelessSessionImplementor statelessSession ) { |
Check notice
Code scanning / CodeQL
Unread local variable
| * @param vwu Performed work unit. | ||
| */ | ||
| public void entityChanged(Session session, Object currentRevisionData, AuditWorkUnit vwu) { | ||
| public void entityChanged(SharedSessionContractImplementor session, Object currentRevisionData, AuditWorkUnit vwu) { |
Check notice
Code scanning / CodeQL
Useless parameter
# Conflicts: # hibernate-core/src/main/java/org/hibernate/engine/spi/AbstractDelegatingSharedSessionBuilder.java # hibernate-core/src/main/java/org/hibernate/event/internal/DefaultLockEventListener.java # hibernate-core/src/main/java/org/hibernate/internal/StatelessSessionImpl.java # Conflicts: # hibernate-core/src/main/java/org/hibernate/cache/internal/CollectionCacheInvalidator.java
| @Override | ||
| SharedStatelessSessionBuilder noInterceptor(); | ||
|
|
||
| SharedStatelessSessionBuilder statementInspector(UnaryOperator<String> operator); |
Check notice
Code scanning / CodeQL
Missing Override annotation
| SessionBuilderImplementor tenantIdentifier(String tenantIdentifier); | ||
|
|
||
| @Override | ||
| SessionBuilderImplementor tenantIdentifier(Object tenantIdentifier); |
Check notice
Code scanning / CodeQL
Confusing overloading of methods
sebersole
force-pushed
the
EventSource
branch
from
656262d to
db819d5
Compare
|
Fixed conflicts and integrated manually |
|
👏👏 Fantastic, this all looks great! One small nitpick: I'm not sure about the package for the new incubating APIs. I can see why you don't want to throw them into |
2 participants
Invesigate proper support for certain events (
AbstractDatabaseOperationEventand friends) fromStatelessSession.hibernate/hibernate-reactive#394
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19737