Skip to content

HHH-19711 Improve mapped-by + join-column exception message with the full property path #10760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

HHH-19711 Improve mapped-by + join-column exception message with the full property path #10760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfcf24f
HHH-19711 Add test for issue
dreab8 Aug 14, 2025
5c86efb
HHH-19711 Improve mapped-by + join-column exception message with the …
dreab8 Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions hibernate-core/src/main/java/org/hibernate/boot/model/internal/AnnotatedJoinColumn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
import jakarta.persistence.JoinColumn;
import jakarta.persistence.PrimaryKeyJoinColumn;

import static org.hibernate.boot.model.internal.BinderHelper.getRelativePath;
import java.util.Locale;

import static org.hibernate.internal.util.StringHelper.isEmpty;
import static org.hibernate.internal.util.StringHelper.isNotEmpty;
import static org.hibernate.internal.util.StringHelper.isQuoted;
Expand Down Expand Up @@ -109,9 +110,13 @@ static AnnotatedJoinColumn buildJoinColumn(
String defaultColumnSuffix) {
if ( joinColumn != null ) {
if ( mappedBy != null ) {
throw new AnnotationException( "Association '"
+ getRelativePath( propertyHolder, inferredData.getPropertyName() )
+ "' is 'mappedBy' a different entity and may not explicitly specify the '@JoinColumn'" );
throw new AnnotationException(
String.format(
Locale.ROOT,
"Association '%s' of entity '%s' is 'mappedBy' a different entity and may not explicitly specify the '@JoinColumn'",
inferredData.getPropertyName(),
propertyHolder.getEntityName() )
);
}
return explicitJoinColumn( joinColumn, parent, inferredData, defaultColumnSuffix );
}
Expand Down
8 changes: 7 additions & 1 deletion ...test/java/org/hibernate/orm/test/annotations/onetoone/OverrideOneToOneJoinColumnTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,16 @@ public void disallowOnSideWithMappedBy() {
.buildMetadata()
);

String errorMessage = ex.getMessage();
assertTrue(
ex.getMessage().contains( "is 'mappedBy' a different entity and may not explicitly specify the '@JoinColumn'" ),
errorMessage.contains( "is 'mappedBy' a different entity and may not explicitly specify the '@JoinColumn'" ),
"Should disallow exactly because of @JoinColumn override on side with mappedBy"
);
assertTrue( errorMessage.contains( "Association 'desk'" ),
"The error message doesn't contain the name of the association" );
assertTrue( errorMessage.contains( PartTimeEmployee.class.getSimpleName() ),
"The error message doesn't contain the name of the entity" );

}
}

Expand Down