Skip to content

Fix lock handling for HANA #10767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2025
Merged

Fix lock handling for HANA #10767

merged 2 commits into from
Aug 21, 2025

Conversation

beikov
Copy link
Member

@beikov beikov commented Aug 15, 2025

[Please describe here what your change is about]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

@beikov beikov added the hana label Aug 15, 2025
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Aug 15, 2025 •
edited
Loading

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [12252c4, eb845ec]

› This message was automatically generated.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 15, 2025
View reviewed changes
...nate-community-dialects/src/main/java/org/hibernate/community/dialect/HANALegacyDialect.java
}
private String withTimeout(String lockString, int timeout) {
return switch (timeout) {
case Timeouts.NO_WAIT_MILLI -> supportsNoWait() ? lockString + " nowait" : lockString;

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Dialect.supportsNoWait
Loading
should be avoided because it has been deprecated.
...nate-community-dialects/src/main/java/org/hibernate/community/dialect/HANALegacyDialect.java
private String withTimeout(String lockString, int timeout) {
return switch (timeout) {
case Timeouts.NO_WAIT_MILLI -> supportsNoWait() ? lockString + " nowait" : lockString;
case Timeouts.SKIP_LOCKED_MILLI -> supportsSkipLocked() ? lockString + SQL_IGNORE_LOCKED : lockString;

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Dialect.supportsSkipLocked
Loading
should be avoided because it has been deprecated.
...nate-community-dialects/src/main/java/org/hibernate/community/dialect/HANALegacyDialect.java
case Timeouts.NO_WAIT_MILLI -> supportsNoWait() ? lockString + " nowait" : lockString;
case Timeouts.SKIP_LOCKED_MILLI -> supportsSkipLocked() ? lockString + SQL_IGNORE_LOCKED : lockString;
case Timeouts.WAIT_FOREVER_MILLI -> lockString;
default -> supportsWait() ? lockString + " wait " + getTimeoutInSeconds( timeout ) : lockString;

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Dialect.supportsWait
Loading
should be avoided because it has been deprecated.
...nate-community-dialects/src/main/java/org/hibernate/community/dialect/HANALegacyDialect.java
case Timeouts.NO_WAIT_MILLI -> supportsNoWait() ? lockString + " nowait" : lockString;
case Timeouts.SKIP_LOCKED_MILLI -> supportsSkipLocked() ? lockString + SQL_IGNORE_LOCKED : lockString;
case Timeouts.WAIT_FOREVER_MILLI -> lockString;
default -> supportsWait() ? lockString + " wait " + getTimeoutInSeconds( timeout ) : lockString;

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Dialect.getTimeoutInSeconds
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/dialect/HANADialect.java
}
private String withTimeout(String lockString, int timeout) {
return switch (timeout) {
case Timeouts.NO_WAIT_MILLI -> supportsNoWait() ? lockString + " nowait" : lockString;

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Dialect.supportsNoWait
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/dialect/HANADialect.java
private String withTimeout(String lockString, int timeout) {
return switch (timeout) {
case Timeouts.NO_WAIT_MILLI -> supportsNoWait() ? lockString + " nowait" : lockString;
case Timeouts.SKIP_LOCKED_MILLI -> supportsSkipLocked() ? lockString + SQL_IGNORE_LOCKED : lockString;

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Dialect.supportsSkipLocked
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/dialect/HANADialect.java
case Timeouts.NO_WAIT_MILLI -> supportsNoWait() ? lockString + " nowait" : lockString;
case Timeouts.SKIP_LOCKED_MILLI -> supportsSkipLocked() ? lockString + SQL_IGNORE_LOCKED : lockString;
case Timeouts.WAIT_FOREVER_MILLI -> lockString;
default -> supportsWait() ? lockString + " wait " + getTimeoutInSeconds( timeout ) : lockString;

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Dialect.supportsWait
Loading
should be avoided because it has been deprecated.
hibernate-core/src/main/java/org/hibernate/dialect/HANADialect.java
case Timeouts.NO_WAIT_MILLI -> supportsNoWait() ? lockString + " nowait" : lockString;
case Timeouts.SKIP_LOCKED_MILLI -> supportsSkipLocked() ? lockString + SQL_IGNORE_LOCKED : lockString;
case Timeouts.WAIT_FOREVER_MILLI -> lockString;
default -> supportsWait() ? lockString + " wait " + getTimeoutInSeconds( timeout ) : lockString;

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
Dialect.getTimeoutInSeconds
Loading
should be avoided because it has been deprecated.
@beikov beikov force-pushed the hana-fixes branch 2 times, most recently from 1cf74a8 to b2ec9c1 Compare August 19, 2025 16:54
@beikov beikov merged commit 3b0c822 into hibernate:main Aug 21, 2025
24 of 27 checks passed
@beikov beikov deleted the hana-fixes branch August 21, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

hana

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@beikov