Skip to content

Conversation

gavinking
Copy link
Member

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Aug 18, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [1dff749, e368b81, 12d77c0, fcd6cef]

› This message was automatically generated.

: persister.getElementType();
final Type whereType =
persister.hasIndex()
? persister.getIndexType()

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
CollectionPersister.getIndexType
should be avoided because it has been deprecated.
final Type whereType =
persister.hasIndex()
? persister.getIndexType()
: persister.getElementType();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
CollectionPersister.getElementType
should be avoided because it has been deprecated.
}

final CollectionType collectionType = collectionPersister.getCollectionType();
final var collectionType = collectionPersister.getCollectionType();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
CollectionPersister.getCollectionType
should be avoided because it has been deprecated.
return null;
}
return collection != null && Hibernate.isInitialized( collection )
? collectionPersister.getCollectionType().indexOf( collection, childEntity )

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
CollectionPersister.getCollectionType
should be avoided because it has been deprecated.
final PreInsertEvent event = new PreInsertEvent( entity, id, state, persister, null );
for ( PreInsertEventListener listener : eventListenerGroups.eventListenerGroup_PRE_INSERT.listeners() ) {
final var event = new PreInsertEvent( entity, id, state, persister, null );
for ( var listener : eventListenerGroups.eventListenerGroup_PRE_INSERT.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
should be avoided because it has been deprecated.
final PreUpdateEvent event = new PreUpdateEvent( entity, id, state, null, persister, null );
for ( PreUpdateEventListener listener : eventListenerGroups.eventListenerGroup_PRE_UPDATE.listeners() ) {
final var event = new PreUpdateEvent( entity, id, state, null, persister, null );
for ( var listener : eventListenerGroups.eventListenerGroup_PRE_UPDATE.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
should be avoided because it has been deprecated.
final PreUpsertEvent event = new PreUpsertEvent( entity, id, state, persister, null );
for ( PreUpsertEventListener listener : eventListenerGroups.eventListenerGroup_PRE_UPSERT.listeners() ) {
final var event = new PreUpsertEvent( entity, id, state, persister, null );
for ( var listener : eventListenerGroups.eventListenerGroup_PRE_UPSERT.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
should be avoided because it has been deprecated.
final PreDeleteEvent event = new PreDeleteEvent( entity, id, null, persister, null );
for ( PreDeleteEventListener listener : eventListenerGroups.eventListenerGroup_PRE_DELETE.listeners() ) {
final var event = new PreDeleteEvent( entity, id, null, persister, null );
for ( var listener : eventListenerGroups.eventListenerGroup_PRE_DELETE.listeners() ) {

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
EventListenerGroup.listeners
should be avoided because it has been deprecated.
and refactor away a dupe method
@gavinking gavinking marked this pull request as ready for review August 18, 2025 01:57
@gavinking gavinking merged commit f4fc2b9 into hibernate:main Aug 18, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant