HHH-19719 org.hibernate.query.sqm.function.SelfRenderingSqmWindowFunction#appendHqlString throws IndexOutOfBoundsException when has no arguments #10783
+65
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but please use the Jira issue key in the commit messages |
cigaly
force-pushed
the
HHH-19719-org.hibernate.query.sqm.function.SelfRenderingSqmWindowFunction.appendHqlString_no_arguments
branch
from
8f30653 to
098db61
Compare
Sorry, my fault. It is fixed now |
beikov
approved these changes
Aug 19, 2025
…ments, appendHqlString throws IndexOutOfBoundsException
cigaly
force-pushed
the
HHH-19719-org.hibernate.query.sqm.function.SelfRenderingSqmWindowFunction.appendHqlString_no_arguments
branch
from
098db61 to
fb97d30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue HHH-19719
Checking if list of arguments is non empty before checking if first argument is instance of
SqmDistinct. If empty, condition is definitely false :-)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19719