lots of use of var in boot.model.internal #10810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hibernate-core/src/main/java/org/hibernate/boot/model/internal/EntityBinder.java
Fixed
Show fixed
Hide fixed
| return !Objects.equals( type, Generator.class ) ? type.getName() : generatorConfig.strategy(); | ||
| final var generatorClass = generatorConfig.type(); | ||
| return Generator.class.equals( generatorClass ) | ||
| ? generatorConfig.strategy() |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
gavinking
force-pushed
the
var-in-boot-model
branch
from
e4439ee to
ff7cc0c
Compare
| final int joinColumnCount = | ||
| primaryKeyJoinColumns != null | ||
| ? primaryKeyJoinColumns.length | ||
| : joinColumns.length; |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
gavinking
force-pushed
the
var-in-boot-model
branch
2 times, most recently
from
cc8121e to
607da81
Compare
gavinking
force-pushed
the
var-in-boot-model
branch
from
607da81 to
7141ee9
Compare
gavinking
force-pushed
the
var-in-boot-model
branch
from
6cf35e9 to
ed16b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might have gone a little too far on some of this, but it's a learning process.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.