HHH-14082 Apply version injection plugin #10836
Merged
+18
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-bekhta
force-pushed
the
build/use-injection-plugin-for-version
branch
2 times, most recently
from
aa018d5 to
38653d6
Compare
mbellade
reviewed
Sep 30, 2025
| id "local.publishing-java-module" | ||
| id "local.publishing-group-relocation" | ||
| id "org.hibernate.build.version-injection" | ||
| id "org.hibernate.build.version-injection" apply true |
There was a problem hiding this comment.
Does apply true do anything here? Isn't that the default?
There was a problem hiding this comment.
good point 👍🏻
There's one disabled in the main build file (apply false) and I think initially the version was not injected, so I had the apply true added but looking at this again it seems it's fine to remove it.
updated+rebased, let's merge once the build is 🟢
hibernate-core/hibernate-core.gradle
Outdated
| id "local.publishing-java-module" | ||
| id "local.publishing-group-relocation" | ||
|
|
||
| id "org.hibernate.build.version-injection" apply true |
There was a problem hiding this comment.
Does apply true do anything here? Isn't that the default?
marko-bekhta
force-pushed
the
build/use-injection-plugin-for-version
branch
from
38653d6 to
931a0f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-14082
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.