Skip to content

Conversation

@jrenaat
Copy link
Member

@jrenaat jrenaat commented Aug 28, 2025


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18686

@jrenaat jrenaat requested a review from beikov August 28, 2025 17:26
@beikov
Copy link
Member

beikov commented Aug 29, 2025

I don't see a need to allow parameterizing the forceOrderColumns flag. This flag is only useful if the Metadata object is reused for multiple schema export tasks, which it isn't here. IMO, the flag is usually only useful for tests to avoid redoing boot model building when testing multiple scenarios.

…espect to ordering columns and metadata validation

Signed-off-by: Jan Schatteman <[email protected]>
@jrenaat jrenaat force-pushed the HHH-18686_schemaexport branch from 3862fb3 to 05f7d78 Compare August 29, 2025 14:36
@jrenaat jrenaat merged commit 0189680 into hibernate:main Aug 29, 2025
26 checks passed
@jrenaat jrenaat deleted the HHH-18686_schemaexport branch August 29, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants