Skip to content

Fix MutationDelegateTest insert and update query assertions #10864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

Fix MutationDelegateTest insert and update query assertions #10864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../java/org/hibernate/orm/test/mapping/generated/delegate/MutationDelegateIdentityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public void testUpdateGeneratedValuesAndIdentity(SessionFactoryScope scope) {
assertThat( entity.getUpdateDate() ).isNotNull();

inspector.assertIsSelect( 0 );
assertThat( inspector.getSqlQueries().get( 0 ) ).contains( "update" );
assertThat( inspector.getSqlQueries().get( 1 ) ).contains( "update " );
inspector.assertExecutedCount(
delegate != null && delegate.supportsArbitraryValues() ? 2 : 3
);
Expand Down Expand Up @@ -188,7 +188,7 @@ public void testInsertGeneratedValuesAndIdentityAndRowId(SessionFactoryScope sco

assertThat( entity.getUpdateDate() ).isNotNull();

assertThat( inspector.getSqlQueries().get( 0 ) ).contains( "update" );
assertThat( inspector.getSqlQueries().get( 0 ) ).contains( "update " );
inspector.assertNumberOfOccurrenceInQueryNoSpace( 0, "id_column", shouldHaveRowId ? 0 : 1 );
} );
scope.inSession( session -> assertThat( session.find(
Expand Down
4 changes: 2 additions & 2 deletions .../hibernate/orm/test/mapping/generated/delegate/MutationDelegateJoinedInheritanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public void testUpdateBaseEntity(SessionFactoryScope scope) {
assertThat( entity.getUpdateDate() ).isNotNull();

inspector.assertIsSelect( 0 );
assertThat( inspector.getSqlQueries().get( 0 ) ).contains( "update" );
assertThat( inspector.getSqlQueries().get( 1 ) ).contains( "update " );
inspector.assertExecutedCount(
delegate != null && delegate.supportsArbitraryValues() ? 2 : 3
);
Expand Down Expand Up @@ -174,7 +174,7 @@ public void testUpdateChildEntity(SessionFactoryScope scope) {
assertThat( entity.getChildUpdateDate() ).isNotNull();

inspector.assertIsSelect( 0 );
assertThat( inspector.getSqlQueries().get( 0 ) ).contains( "update" );
assertThat( inspector.getSqlQueries().get( 1 ) ).contains( "update " );
// Note: this is a current restriction, mutation delegates only retrieve generated values
// on the "root" table, and we expect other values to be read through a subsequent select
inspector.assertIsSelect( 2 );
Expand Down
4 changes: 2 additions & 2 deletions ...src/test/java/org/hibernate/orm/test/mapping/generated/delegate/MutationDelegateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public void testUpdateGeneratedValues(SessionFactoryScope scope) {
assertThat( entity.getUpdateDate() ).isNotNull();

inspector.assertIsSelect( 0 );
assertThat( inspector.getSqlQueries().get( 0 ) ).contains( "update" );
assertThat( inspector.getSqlQueries().get( 1 ) ).contains( "update " );
inspector.assertExecutedCount(
delegate != null && delegate.supportsArbitraryValues() ? 2 : 3
);
Expand Down Expand Up @@ -133,7 +133,7 @@ public void testGeneratedValuesAndRowId(SessionFactoryScope scope) {
session.flush();

assertThat( entity.getUpdateDate() ).isNotNull();
assertThat( inspector.getSqlQueries().get( 0 ) ).contains( "update" );
assertThat( inspector.getSqlQueries().get( 0 ) ).contains( "update " );
inspector.assertNumberOfOccurrenceInQueryNoSpace( 0, "id_column", shouldHaveRowId ? 0 : 1 );
} );
scope.inSession( session -> assertThat( session.find( ValuesAndRowId.class, 1 ).getUpdateDate() ).isNotNull() );
Expand Down
Loading