HHH-19556 Introduce SqmCacheable for query caching via #isCompatible and #cacheHashCode instead of equals/hashCode #10899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2025
Closed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| else { | ||
| final Set<SqmParameter<?>> parameters = new HashSet<>( this.parameters.size() ); | ||
| final Set<SqmParameter<?>> parameters = new LinkedHashSet<>( this.parameters.size() ); |
Check notice
Code scanning / CodeQL
Possible confusion of local and field Note
| return e1 == null ? e2 == null : e1.isCompatible( e2 ); | ||
| } | ||
|
|
||
| static boolean areCompatible(@Nullable Collection<? extends SqmCacheable> collection1, @Nullable Collection<? extends SqmCacheable> collection2) { |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| * @author Christian Beikov | ||
| */ | ||
| public class SqmCteTable<T> extends AnonymousTupleType<T> implements JpaCteCriteriaType<T> { | ||
| public class SqmCteTable<T> extends AnonymousTupleType<T> implements JpaCteCriteriaType<T>, SqmCacheable { |
Check warning
Code scanning / CodeQL
Serializable but no void constructor Warning
| ? one.getPosition().compareTo( o2.getPosition() ) | ||
| : 1; | ||
| } | ||
| throw new HibernateException( "Unexpected SqmParameter type for comparison : " + this + " & " + o2 ); |
Check notice
Code scanning / CodeQL
Use of default toString() Note
| } | ||
|
|
||
| public List<SqmJoin<?, ?>> getOrderedJoins() { | ||
| public @Nullable List<SqmJoin<?, ?>> getOrderedJoins() { |
Check notice
Code scanning / CodeQL
Exposing internal representation Note
…and #cacheHashCode instead of equals/hashCode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19556