Skip to content

Misc fixes for timestamp related intermittent test failures #10905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

Misc fixes for timestamp related intermittent test failures #10905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions hibernate-core/src/test/java/org/hibernate/orm/test/jpa/metadata/Record.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ public class Record {
@Id @GeneratedValue
String id;
String text;
LocalDateTime timestamp = LocalDateTime.now();
LocalDateTime timestamp;
Record() {}
public Record(String text) {
public Record(String text, LocalDateTime timestamp) {
this.text = text;
this.timestamp = timestamp;
}
}
12 changes: 3 additions & 9 deletions hibernate-core/src/test/java/org/hibernate/orm/test/jpa/metadata/TypesafeNamedQueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,27 +4,21 @@
*/
package org.hibernate.orm.test.jpa.metadata;

import org.hibernate.community.dialect.FirebirdDialect;
import org.hibernate.community.dialect.InformixDialect;
import org.hibernate.dialect.SybaseASEDialect;
import org.hibernate.testing.orm.junit.EntityManagerFactoryScope;
import org.hibernate.testing.orm.junit.Jpa;
import org.hibernate.testing.orm.junit.SkipForDialect;
import org.junit.jupiter.api.Test;

import java.time.LocalDate;
import java.util.List;

import static org.junit.jupiter.api.Assertions.assertEquals;

@Jpa(annotatedClasses = Record.class)
public class TypesafeNamedQueryTest {
@SkipForDialect(dialectClass = SybaseASEDialect.class, reason = "'order by timestamp, id' not quite working")
@SkipForDialect(dialectClass = FirebirdDialect.class, reason = "'order by timestamp, id' not quite working")
@SkipForDialect(dialectClass = InformixDialect.class, reason = "'order by timestamp, id' not quite working")
@Test void test(EntityManagerFactoryScope scope) {
scope.inTransaction( entityManager -> {
Record record1 = new Record("Hello, World!");
Record record2 = new Record("Goodbye!");
Record record1 = new Record("Hello, World!", LocalDate.EPOCH.atStartOfDay());
Record record2 = new Record("Goodbye!", LocalDate.EPOCH.atStartOfDay().plusSeconds( 1L ));
entityManager.persist(record1);
entityManager.persist(record2);
String text = entityManager.createQuery(Record_._TextById_).setParameter(1, record1.id).getSingleResult();
Expand Down
3 changes: 3 additions & 0 deletions hibernate-core/src/test/java/org/hibernate/orm/test/query/SubQueryShadowingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.Id;
import org.hibernate.testing.orm.junit.DialectFeatureChecks;
import org.hibernate.testing.orm.junit.DomainModel;
import org.hibernate.testing.orm.junit.Jira;
import org.hibernate.testing.orm.junit.RequiresDialectFeature;
import org.hibernate.testing.orm.junit.SessionFactory;
import org.hibernate.testing.orm.junit.SessionFactoryScope;
import org.junit.jupiter.api.Test;
Expand All @@ -23,6 +25,7 @@
public class SubQueryShadowingTest {

@Test
@RequiresDialectFeature(feature = DialectFeatureChecks.SupportsOffsetInSubquery.class, comment = "The check is for both, limit and offset in subqueries")
@Jira("https://hibernate.atlassian.net/browse/HHH-19745")
public void testSelectCase(SessionFactoryScope scope) {
scope.inTransaction( session -> {
Expand Down
Loading