HHH-19790 - Fix Gradle Worker ID gaps for parallel testing #10970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| final ByteBuffer bb = ByteBuffer.allocate( Long.BYTES * maxParallelForks ); | ||
| do { | ||
| try (FileLock lock = fc.lock( 0L, Long.MAX_VALUE, true )) { | ||
| final int bytesRead = fc.read( bb, 0 ); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
| file.seek( length ); | ||
| final ByteBuffer bb = ByteBuffer.allocate( Long.BYTES ); | ||
| bb.asLongBuffer().put( new long[] {id} ); | ||
| final int bytesWritten = fc.write( bb ); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
Member
|
I'm not an expert and this level of Gradle parallelism, but this seems reasonable to me and causes no problems and @loiclefevre says it fixes the issues I see randomly on PR Actions. If I hear no objections by tomorrow, going to apply it. |
beikov
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a fix for the Gradle Worker ID generation used for parallel testing; it indeed prevents "holes" in the sequence of generated IDs using a common file to synchronize all forked JVMs. As a result, there is no more possibility for 2 distinct JVMs to map onto the same targeted JDBC user.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19790