Skip to content

HHH-19768 Make DB2Dialect return true for supportsRowValueConstructorSyntaxInInSubQuery #10990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

HHH-19768 Make DB2Dialect return true for supportsRowValueConstructorSyntaxInInSubQuery #10990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a735b7
HHH-19768 Make DB2Dialect return true for supportsRowValueConstructor…
beikov Sep 11, 2025
402e931
HHH-19768 Prefer values list rendering to emulate in-list tuples over…
beikov Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...te-community-dialects/src/main/java/org/hibernate/community/dialect/DB2LegacyDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1499,4 +1499,9 @@ public boolean supportsRowValueConstructorSyntaxInInList() {
return false;
}

@Override
public boolean supportsRowValueConstructorSyntaxInInSubQuery() {
return true;
}

}
3 changes: 3 additions & 0 deletions ...e-community-dialects/src/main/java/org/hibernate/community/dialect/HSQLLegacyDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,6 +912,7 @@ public boolean supportsArrayConstructor() {

@Override
public boolean supportsRowValueConstructorSyntax() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

Expand All @@ -923,11 +924,13 @@ public boolean supportsWithClauseInSubquery() {

@Override
public boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

@Override
public boolean supportsRowValueConstructorSyntaxInInList() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

Expand Down
5 changes: 5 additions & 0 deletions hibernate-core/src/main/java/org/hibernate/dialect/DB2Dialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,4 +1273,9 @@ public boolean supportsRowValueConstructorSyntaxInInList() {
return false;
}

@Override
public boolean supportsRowValueConstructorSyntaxInInSubQuery() {
return true;
}

}
3 changes: 3 additions & 0 deletions hibernate-core/src/main/java/org/hibernate/dialect/HSQLDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,7 @@ public boolean supportsArrayConstructor() {

@Override
public boolean supportsRowValueConstructorSyntax() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

Expand All @@ -757,11 +758,13 @@ public boolean supportsWithClauseInSubquery() {

@Override
public boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

@Override
public boolean supportsRowValueConstructorSyntaxInInList() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

Expand Down
19 changes: 18 additions & 1 deletion hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7664,7 +7664,24 @@ public void visitInListPredicate(InListPredicate inListPredicate) {
}
else if ( !dialect.supportsRowValueConstructorSyntaxInInList() ) {
// Some DBs like Oracle support tuples only for the IN subquery predicate
if ( dialect.supportsRowValueConstructorSyntaxInInSubQuery() && dialect.supportsUnionAll() ) {
if ( dialect.supportsRowValueConstructorSyntaxInInSubQuery() && dialect.supportsValuesList() ) {
inListPredicate.getTestExpression().accept( this );
if ( inListPredicate.isNegated() ) {
appendSql( " not" );
}
appendSql( " in (select * from (values" );
char separator = ' ';
for ( Expression expression : listExpressions ) {
appendSql( separator );
appendSql( OPEN_PARENTHESIS );
renderCommaSeparated( getSqlTuple( expression ).getExpressions() );
appendSql( CLOSE_PARENTHESIS );
separator = ',';
}
appendSql( CLOSE_PARENTHESIS );
appendSql( CLOSE_PARENTHESIS );
}
else if ( dialect.supportsRowValueConstructorSyntaxInInSubQuery() && dialect.supportsUnionAll() ) {
inListPredicate.getTestExpression().accept( this );
if ( inListPredicate.isNegated() ) {
appendSql( " not" );
Expand Down