Skip to content

HHH-19768 Make DB2Dialect return true for supportsRowValueConstructorSyntaxInInSubQuery #10991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

HHH-19768 Make DB2Dialect return true for supportsRowValueConstructorSyntaxInInSubQuery #10991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faf4dd5
HHH-19768 Make DB2Dialect return true for supportsRowValueConstructor…
beikov Sep 11, 2025
e33a2ca
HHH-19768 Prefer values list rendering to emulate in-list tuples over…
beikov Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...ity-dialects/src/main/java/org/hibernate/community/dialect/DB2LegacySqlAstTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,15 +597,20 @@ protected boolean supportsRowValueConstructorSyntax() {
}

@Override
protected boolean supportsRowValueConstructorSyntaxInInList() {
protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
return false;
}

@Override
protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
protected boolean supportsRowValueConstructorSyntaxInInList() {
return false;
}

@Override
protected boolean supportsRowValueConstructorSyntaxInInSubQuery() {
return true;
}

@Override
protected void visitReturningColumns(List<ColumnReference> returningColumns) {
// For DB2 we use #renderReturningClause to render a wrapper around the DML statement
Expand Down
7 changes: 5 additions & 2 deletions ...ty-dialects/src/main/java/org/hibernate/community/dialect/HSQLLegacySqlAstTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,16 +328,19 @@ else if ( expression instanceof Summarization ) {

@Override
protected boolean supportsRowValueConstructorSyntax() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

@Override
protected boolean supportsRowValueConstructorSyntaxInInList() {
protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

@Override
protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
protected boolean supportsRowValueConstructorSyntaxInInList() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

Expand Down
9 changes: 7 additions & 2 deletions hibernate-core/src/main/java/org/hibernate/dialect/DB2SqlAstTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,15 +578,20 @@ protected boolean supportsRowValueConstructorSyntax() {
}

@Override
protected boolean supportsRowValueConstructorSyntaxInInList() {
protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
return false;
}

@Override
protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
protected boolean supportsRowValueConstructorSyntaxInInList() {
return false;
}

@Override
protected boolean supportsRowValueConstructorSyntaxInInSubQuery() {
return true;
}

@Override
protected void visitReturningColumns(List<ColumnReference> returningColumns) {
// For DB2 we use #renderReturningClause to render a wrapper around the DML statement
Expand Down
7 changes: 5 additions & 2 deletions hibernate-core/src/main/java/org/hibernate/dialect/HSQLSqlAstTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,16 +322,19 @@ else if ( expression instanceof Summarization ) {

@Override
protected boolean supportsRowValueConstructorSyntax() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

@Override
protected boolean supportsRowValueConstructorSyntaxInInList() {
protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

@Override
protected boolean supportsRowValueConstructorSyntaxInQuantifiedPredicates() {
protected boolean supportsRowValueConstructorSyntaxInInList() {
// It's supported but not usable due to a bug: https://sourceforge.net/p/hsqldb/bugs/1714/
return false;
}

Expand Down
19 changes: 18 additions & 1 deletion hibernate-core/src/main/java/org/hibernate/sql/ast/spi/AbstractSqlAstTranslator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7753,7 +7753,24 @@ public void visitInListPredicate(InListPredicate inListPredicate) {
}
else if ( !supportsRowValueConstructorSyntaxInInList() ) {
// Some DBs like Oracle support tuples only for the IN subquery predicate
if ( supportsRowValueConstructorSyntaxInInSubQuery() && dialect.supportsUnionAll() ) {
if ( supportsRowValueConstructorSyntaxInInSubQuery() && dialect.supportsValuesList() ) {
inListPredicate.getTestExpression().accept( this );
if ( inListPredicate.isNegated() ) {
appendSql( " not" );
}
appendSql( " in (select * from (values" );
char separator = ' ';
for ( Expression expression : listExpressions ) {
appendSql( separator );
appendSql( OPEN_PARENTHESIS );
renderCommaSeparated( SqlTupleContainer.getSqlTuple( expression ).getExpressions() );
appendSql( CLOSE_PARENTHESIS );
separator = ',';
}
appendSql( CLOSE_PARENTHESIS );
appendSql( CLOSE_PARENTHESIS );
}
else if ( supportsRowValueConstructorSyntaxInInSubQuery() && dialect.supportsUnionAll() ) {
inListPredicate.getTestExpression().accept( this );
if ( inListPredicate.isNegated() ) {
appendSql( " not" );
Expand Down
Loading