-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-18936 remove parent with @OnDelete(CASCADE) leads to TransientObjectException #11003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hibernate-core/src/main/java/org/hibernate/engine/spi/CascadingAction.java
Outdated
Show resolved
Hide resolved
...ate-core/src/test/java/org/hibernate/orm/test/ondeletecascade/OnDeleteCascadeRemoveTest.java
Show resolved
Hide resolved
e24168e
to
adbe905
Compare
@@ -0,0 +1,122 @@ | |||
/* | |||
* SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the LGPL headers here and in all the other files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised this didn't fail the build... Is it just that such checks are only present in newer branches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the check is not performed for tests classes
For some reason, I can't reproduce the Sybase failure locally. Were you able to @dreab8 ? |
no I don't but looking at the failing test it seems unrelated with the changes of this PR |
Finally figured it out, you're missing this commit: cd55e5b |
209ef22
to
bb6d1c4
Compare
https://hibernate.atlassian.net/browse/HHH-18936
bacport to 6.6 of #10250 and #10251.
The backport does not nclude this commit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.