Skip to content

Conversation

dreab8
Copy link
Member

@dreab8 dreab8 commented Sep 25, 2025

https://hibernate.atlassian.net/browse/HHH-18936

bacport to 6.6 of #10250 and #10251.

The backport does not nclude this commit


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@@ -0,0 +1,122 @@
/*
* SPDX-License-Identifier: Apache-2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the LGPL headers here and in all the other files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this didn't fail the build... Is it just that such checks are only present in newer branches?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the check is not performed for tests classes

@beikov
Copy link
Member

beikov commented Sep 25, 2025

For some reason, I can't reproduce the Sybase failure locally. Were you able to @dreab8 ?

@dreab8
Copy link
Member Author

dreab8 commented Sep 25, 2025

no I don't but looking at the failing test it seems unrelated with the changes of this PR

@beikov
Copy link
Member

beikov commented Sep 25, 2025

Finally figured it out, you're missing this commit: cd55e5b

@dreab8 dreab8 merged commit b342616 into hibernate:6.6 Sep 29, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants