-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19805 Allow nested entity initializers to claim entity holder #11008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
174 changes: 174 additions & 0 deletions
174
...ate-core/src/test/java/org/hibernate/orm/test/collection/set/PersistentSetRemoveTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,174 @@ | ||
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright Red Hat Inc. and Hibernate Authors | ||
| */ | ||
| package org.hibernate.orm.test.collection.set; | ||
|
|
||
| import jakarta.persistence.CascadeType; | ||
| import jakarta.persistence.Entity; | ||
| import jakarta.persistence.FetchType; | ||
| import jakarta.persistence.Id; | ||
| import jakarta.persistence.ManyToOne; | ||
| import jakarta.persistence.OneToMany; | ||
| import org.hibernate.testing.orm.junit.DomainModel; | ||
| import org.hibernate.testing.orm.junit.Jira; | ||
| import org.hibernate.testing.orm.junit.SessionFactory; | ||
| import org.hibernate.testing.orm.junit.SessionFactoryScope; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.util.HashSet; | ||
| import java.util.Objects; | ||
| import java.util.Set; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| @DomainModel(annotatedClasses = { | ||
| PersistentSetRemoveTest.Parent.class, | ||
| PersistentSetRemoveTest.Child.class | ||
| }) | ||
| @SessionFactory | ||
| @Jira("https://hibernate.atlassian.net/browse/HHH-19805") | ||
| public class PersistentSetRemoveTest { | ||
|
|
||
| @Test | ||
| public void testRemove(SessionFactoryScope scope) { | ||
| Parent p1 = new Parent( 1L, "p1" ); | ||
| Child c1 = new Child( 1L, "c1" ); | ||
| Child c2 = new Child( 2L, "c2" ); | ||
| Child c3 = new Child( 3L, "c3" ); | ||
| p1.getChildren().add( c1 ); | ||
| c1.setParent( p1 ); | ||
| p1.getChildren().add( c2 ); | ||
| c2.setParent( p1 ); | ||
| p1.getChildren().add( c3 ); | ||
| c3.setParent( p1 ); | ||
|
|
||
| scope.inTransaction( | ||
| session -> session.persist( p1 ) | ||
| ); | ||
|
|
||
| scope.inTransaction( | ||
| session -> { | ||
| Child child = session.createQuery( "from Child c where c.name = :name", Child.class ) | ||
| .setParameter( "name", "c1" ) | ||
| .getSingleResult(); | ||
|
|
||
| boolean removed = child.getParent().getChildren().remove( child ); | ||
| assertTrue( removed ); | ||
| } | ||
| ); | ||
|
|
||
| scope.inTransaction( | ||
| session -> { | ||
| Parent parent = session.find( Parent.class, p1.getId() ); | ||
| Child childToRemove = parent.getChildren().stream() | ||
| .filter( book -> "c2".equals( book.getName() ) ) | ||
| .findFirst() | ||
| .orElseThrow(); | ||
| boolean removed = parent.getChildren().remove( childToRemove ); | ||
| assertTrue( removed ); | ||
| } | ||
| ); | ||
| } | ||
|
|
||
| @Entity(name = "Parent") | ||
| public static class Parent { | ||
| @Id | ||
| private Long id; | ||
| private String name; | ||
|
|
||
| @OneToMany(mappedBy = "parent", cascade = CascadeType.ALL, orphanRemoval = true, fetch = FetchType.EAGER) | ||
| private Set<Child> children; | ||
|
|
||
| public Parent() { | ||
| this.children = new HashSet<>(); | ||
| } | ||
|
|
||
| public Parent(Long id, String name) { | ||
| this.id = id; | ||
| this.name = name; | ||
| this.children = new HashSet<>(); | ||
| } | ||
|
|
||
| public Long getId() { | ||
| return id; | ||
| } | ||
|
|
||
| public void setId(Long id) { | ||
| this.id = id; | ||
| } | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public void setName(String name) { | ||
| this.name = name; | ||
| } | ||
|
|
||
| public Set<Child> getChildren() { | ||
| return children; | ||
| } | ||
|
|
||
| public void setChildren(Set<Child> children) { | ||
| this.children = children; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| @Entity(name = "Child") | ||
| public static class Child { | ||
| @Id | ||
| private Long id; | ||
| private String name; | ||
|
|
||
| @ManyToOne | ||
| private Parent parent; | ||
|
|
||
| public Child() { | ||
| } | ||
|
|
||
| public Child(Long id, String name) { | ||
| this.id = id; | ||
| this.name = name; | ||
| } | ||
|
|
||
| public Long getId() { | ||
| return id; | ||
| } | ||
|
|
||
| public void setId(Long id) { | ||
| this.id = id; | ||
| } | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public void setName(String name) { | ||
| this.name = name; | ||
| } | ||
|
|
||
| public Parent getParent() { | ||
| return parent; | ||
| } | ||
|
|
||
| public void setParent(Parent parent) { | ||
| this.parent = parent; | ||
| } | ||
|
|
||
| @Override | ||
| public final boolean equals(Object o) { | ||
| if ( !(o instanceof Child child) ) { | ||
| return false; | ||
| } | ||
|
|
||
| return Objects.equals( name, child.name ); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hashCode( name ); | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.