HHH-19774 - Automatic flushing for child session with shared connection/tx #11010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private static void setUpTransactionCompletionProcesses( | ||
| SessionCreationOptions options, | ||
| ActionQueue actionQueue, | ||
| SessionImpl childSession) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
gavinking
reviewed
Sep 26, 2025
| * | ||
| * @author Steve Ebersole | ||
| */ | ||
| public interface ParentSessionCallbacks { |
There was a problem hiding this comment.
How about something like FlushObserver?
There was a problem hiding this comment.
Because its also about closing.
There was a problem hiding this comment.
fwiw I did rename it ParentSessionObserver. Listener would have been better too.
gavinking
approved these changes
Sep 26, 2025
sebersole
force-pushed
the
child-sessions
branch
from
9575bcb to
5a8a3a9
Compare
|
The changes cause one test to hang, though just on some databases. Need to investigate some more. |
…on/tx HHH-19808 - Automatic closing for child session with shared connection/tx
…on/tx HHH-19808 - Automatic closing for child session with shared connection/tx
…on/tx HHH-19808 - Automatic closing for child session with shared connection/tx
…on/tx HHH-19808 - Automatic closing for child session with shared connection/tx
sebersole
force-pushed
the
child-sessions
branch
from
cafbc4a to
eddc9b9
Compare
|
Rebased, squashed and applied upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHH-19774 - Automatic flushing for child session with shared connection/tx
HHH-19808 - Automatic closing for child session with shared connection/tx
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19774