Skip to content

Conversation

MoadElfatihi
Copy link
Contributor

Hello ,
This PR aims at minor upgrading for some dependencies.
Thanks
Moad ELFATIHI


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [96fcc46]

› This message was automatically generated.

Copy link
Member

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

Thanks for the PR!

Most of these dependency updates require Jira tickets as they are part of the runtime and have to have a ticket + go into a changelog once released. I've added comments to the ones that require a ticket. If it's only a test dependency, then it's okay not to have a Jira for it.

Please also note for the future, that there is a Dependabot configuration that sends these updates automatically (see https://github.com/hibernate/hibernate-orm/blob/main/.github/dependabot.yml)

def byteBuddyVersion = version "byteBuddy", "1.17.6"
def checkerFrameworkVersion = version "checkerFramework", "3.49.5"
def classmateVersion = version "classmate", "1.7.0"
def byteBuddyVersion = version "byteBuddy", "1.17.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a Jira ticket

def classmateVersion = version "classmate", "1.7.0"
def byteBuddyVersion = version "byteBuddy", "1.17.7"
def checkerFrameworkVersion = version "checkerFramework", "3.51.0"
def classmateVersion = version "classmate", "1.7.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a Jira ticket

def hibernateModelsVersion = version "hibernateModels", "1.0.1"
def jandexVersion = version "jandex", "3.3.1"
def jacksonVersion = version "jackson", "2.19.1"
def jandexVersion = version "jandex", "3.5.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a Jira ticket + needs to be updated in pair with hibernate-models to match the versions.

def jandexVersion = version "jandex", "3.3.1"
def jacksonVersion = version "jackson", "2.19.1"
def jandexVersion = version "jandex", "3.5.0"
def jacksonVersion = version "jackson", "2.20.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a Jira ticket

Comment on lines +89 to +91
def agroalVersion = version "agroal", "2.8"
def c3poVersion = version "c3p0", "0.11.2"
def hikaricpVersion = version "hikaricp", "6.3.0"
def hikaricpVersion = version "hikaricp", "6.3.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two also require their own Jira tickets

def ehcache3Version = version "ehcache3", "3.11.1"

def micrometerVersion = version "micrometer", "1.15.1"
def micrometerVersion = version "micrometer", "1.15.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a Jira ticket

Comment on lines +146 to +147
def jaxbApiVersion = version "jaxbApi", "4.0.4"
def jaxbRuntimeVersion = version "jaxbRuntime", "4.0.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a Jira ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants