HHH-19085 NPE when using null value in CriteriaUpdate #11046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beikov
reviewed
Oct 1, 2025
Comment on lines
2185
to
2189
| if ( value == null ) { | ||
| return new ValueBindJpaCriteriaParameter<>( null, value, this ); | ||
| } | ||
| final var bindableType = resolveInferredParameterType( value, typeInferenceSource, getTypeConfiguration() ); | ||
| if ( bindableType == null || isInstance( bindableType, value) ) { |
There was a problem hiding this comment.
Wouldn't it be better to try retaining the type inference source?
Suggested change
| if ( value == null ) { | |
| return new ValueBindJpaCriteriaParameter<>( null, value, this ); | |
| } | |
| final var bindableType = resolveInferredParameterType( value, typeInferenceSource, getTypeConfiguration() ); | |
| if ( bindableType == null || isInstance( bindableType, value) ) { | |
| final var bindableType = resolveInferredParameterType( value, typeInferenceSource, getTypeConfiguration() ); | |
| if ( bindableType == null || value == null || isInstance( bindableType, value ) ) { |
There was a problem hiding this comment.
see
if we set the type than later on the value is not binded.
There was a problem hiding this comment.
not sure why we are not binding the null value when criteriaParameter.getNodeType() is not null
There was a problem hiding this comment.
It looks like this was added as part of d9446e7, but I doubt that this is still useful. I'd suggest removing the if and always bind the value.
There was a problem hiding this comment.
AbstractSqmSelectionQuery should probably be using this instead: if ( criteriaParameter instanceof ValueBindJpaCriteriaParameter<?> ) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-19085
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.