Skip to content

Conversation

@marko-bekhta
Copy link
Member

https://hibernate.atlassian.net/browse/HHH-19832

opening as a draft since .... we'll (probably?) have the same issues as before, that the bytecodeenhancement engine will be in the way of running some tck tests or something else ...


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@marko-bekhta marko-bekhta marked this pull request as ready for review October 2, 2025 12:19
@marko-bekhta marko-bekhta force-pushed the dep/HHH-19832-Upgrade-to-JUnit-6.0 branch from 6d6e57a to a30d0ef Compare October 2, 2025 12:19
@marko-bekhta marko-bekhta requested a review from yrodiere October 2, 2025 12:19
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Works for me, but we'll need to discuss with the team whether we're fine with upgrading JUnit's major version in a minor version of hibernate-testing.

@marko-bekhta marko-bekhta force-pushed the dep/HHH-19832-Upgrade-to-JUnit-6.0 branch from a30d0ef to f7d5221 Compare October 6, 2025 09:37
@marko-bekhta
Copy link
Member Author

Works for me, but we'll need to discuss with the team whether we're fine with upgrading JUnit's major version in a minor version of hibernate-testing.

+1, I'd also ask if disabling that engine by default is ok to go in the minor or not ... but .. the patch is there, so either 7.2 or 8.0 .. 🫣 🙂

@sebersole
Copy link
Member

Thanks.

Works for me, but we'll need to discuss with the team whether we're fine with upgrading JUnit's major version in a minor version of hibernate-testing.

I think doing this in 7.2 is fine.

@marko-bekhta marko-bekhta force-pushed the dep/HHH-19832-Upgrade-to-JUnit-6.0 branch from f7d5221 to bceb76a Compare October 6, 2025 16:04
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Just minor comments on the migration notes, otherwise feel free to merge :)

@marko-bekhta marko-bekhta force-pushed the dep/HHH-19832-Upgrade-to-JUnit-6.0 branch from 068d266 to 5ef85bc Compare October 6, 2025 16:51
@marko-bekhta marko-bekhta force-pushed the dep/HHH-19832-Upgrade-to-JUnit-6.0 branch from 5ef85bc to 86cc694 Compare October 6, 2025 19:25
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you.

@yrodiere yrodiere merged commit 15b79b7 into hibernate:main Oct 7, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants