-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-19832 Upgrade to JUnit 6.0 #11056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHH-19832 Upgrade to JUnit 6.0 #11056
Conversation
6d6e57a to
a30d0ef
Compare
yrodiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Works for me, but we'll need to discuss with the team whether we're fine with upgrading JUnit's major version in a minor version of hibernate-testing.
...hibernate/testing/bytecode/enhancement/extension/BytecodeEnhancementPostDiscoveryFilter.java
Outdated
Show resolved
Hide resolved
.../org/hibernate/testing/bytecode/enhancement/extension/engine/BytecodeEnhancedTestEngine.java
Show resolved
Hide resolved
a30d0ef to
f7d5221
Compare
+1, I'd also ask if disabling that engine by default is ok to go in the minor or not ... but .. the patch is there, so either 7.2 or 8.0 .. 🫣 🙂 |
I think doing this in 7.2 is fine. |
f7d5221 to
bceb76a
Compare
...hibernate/testing/bytecode/enhancement/extension/BytecodeEnhancementPostDiscoveryFilter.java
Show resolved
Hide resolved
yrodiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Just minor comments on the migration notes, otherwise feel free to merge :)
068d266 to
5ef85bc
Compare
to give more information to the user on possible reasons why the discovery failed.
5ef85bc to
86cc694
Compare
yrodiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you.
https://hibernate.atlassian.net/browse/HHH-19832
opening as a draft since .... we'll (probably?) have the same issues as before, that the bytecodeenhancement engine will be in the way of running some tck tests or something else ...
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.