HHH-19827 Add missing canonical links (follow up) #11089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ rename logging and ServiceRegistries docs to index to match the other ones.
yrodiere
approved these changes
Oct 9, 2025
| @@ -1,5 +1,5 @@ | |||
| :shared-attributes-dir: {doc-main-dir}/asciidoc/shared | |||
| :html-meta-canonical-link: https://docs.jboss.org/hibernate/orm/current/userguide/html_single/Hibernate_User_Guide.html | |||
| :html-meta-canonical-link: https://docs.hibernate.org/stable/orm/userguide/html_single/ | |||
There was a problem hiding this comment.
Apparently these canonical links are new, so changing them shouldn't have a big effect on SEO.
+1.
Comment on lines
+268
to
+288
| def renderTopicalLoggingGuideHtmlTask = tasks.register( 'renderTopicalLoggingGuideHtml', AsciidoctorTask ) { task -> | ||
| group = "Documentation" | ||
| description = 'Renders the Topical Logging Guide in HTML format using Asciidoctor.' | ||
| inputs.property "hibernate-version", hibernateVersion | ||
|
|
||
| sourceDir = file( 'src/main/asciidoc/topical/logging' ) | ||
| sources 'index.adoc' | ||
| outputDir = project.layout.buildDirectory.file( "asciidoc/topical/html_single/logging" ).get().asFile | ||
|
|
||
| resources { | ||
| from( 'src/main/asciidoc/topical/' ) { | ||
| include '**/images/**' | ||
| } | ||
| from(rootProject.layout.buildDirectory.dir("unpacked-theme").get() | ||
| .dir("hibernate-asciidoctor-theme").dir("asciidoc")) { | ||
| include 'css/**' | ||
| include 'images/**' | ||
| include 'script/**' | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I find it wild to duplicate all this code for every single "root" AsciiDoc file.
Would be nice to have some sort of loop, e.g. ['userguide', 'topical/logging', ...].each { ... }.
But... not today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to split the topical render task as in its current form it wasn't applying the styles to the logging/registries pages.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19827