HHH-19862: fix CriteriaUpdate for converted field #11115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbellade
approved these changes
Oct 13, 2025
Member
|
Looks like the new test is failing on Oracle, probably a reserved keyword. While you're looking into that, would you mind adding some assertions to the tests? We could verify that the attributes are correctly updated after running the criteria update. |
Author
|
I'll check this out. Pipeline was ok locally, I'll change the field name to
prevent this (poor name choice)
Yep 👍 for the test enhancement.
Le lun. 13 oct. 2025, 17:44, Marco Belladelli ***@***.***> a
écrit :
… *mbellade* left a comment (hibernate/hibernate-orm#11115)
<#11115 (comment)>
Looks like the new test is failing on Oracle, probably a reserved keyword.
While you're looking into that, would you mind adding some assertions to
the tests? We could verify that the attributes are correctly updated after
running the criteria update.
—
Reply to this email directly, view it on GitHub
<#11115 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOEC35NWHL4RFVF4FEU37KL3XPCFXAVCNFSM6AAAAACJBOL5VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOJYGA2TKNJYGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
Member
|
Thanks, now please squash everything to a single commit and we're good to go. |
Author
|
Done, do you have any idea about what is blocking the pipeline ?
Le mar. 14 oct. 2025, 08:47, Marco Belladelli ***@***.***> a
écrit :
… *mbellade* left a comment (hibernate/hibernate-orm#11115)
<#11115 (comment)>
Thanks, now please squash everything to a single commit and we're good to
go.
—
Reply to this email directly, view it on GitHub
<#11115 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOEC35N6D6FOHQVDM5QSFML3XSL6LAVCNFSM6AAAAACJBOL5VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMBQGM2DSMZRGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
One of the Hibernate maintainers has to approve the pipeline run, I just forgot :) Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19862