Skip to content

Conversation

@MoadElfatihi
Copy link
Contributor

@MoadElfatihi MoadElfatihi commented Nov 15, 2025

Hello,

This change is about removing some unecessary checks for :

  • MySql : the minimum version is already 8
  • Oracle : the minimum version is 19 (so better to set argument to true, I did not change the signature of jsonObject_oracle method as it is used by the OracleLegacyDialect)

Thanks team
Moad ELFATIHI


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Nov 15, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [0dac23b]

› This message was automatically generated.

Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gavinking gavinking merged commit 2fb4775 into hibernate:main Nov 16, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants