Skip to content

HHH-19847 - Drop JUnit 4 support: removed some leftover junit4 references from agroal #11269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
Merged

HHH-19847 - Drop JUnit 4 support: removed some leftover junit4 references from agroal #11269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions hibernate-agroal/src/test/java/org/hibernate/test/agroal/AgroalSkipAutoCommitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
*/
package org.hibernate.test.agroal;

import jakarta.persistence.Entity;
import jakarta.persistence.Id;

import org.hibernate.test.agroal.util.PreparedStatementSpyConnectionProvider;
import org.hibernate.testing.orm.junit.DomainModel;
import org.hibernate.testing.orm.junit.ServiceRegistry;
Expand All @@ -12,8 +15,6 @@
import org.hibernate.testing.orm.junit.Setting;
import org.hibernate.testing.orm.junit.SettingProvider;

import jakarta.persistence.Entity;
import jakarta.persistence.Id;
import org.junit.jupiter.api.Test;

import java.sql.Connection;
Expand All @@ -23,8 +24,8 @@
import static org.hibernate.cfg.JdbcSettings.AUTOCOMMIT;
import static org.hibernate.cfg.JdbcSettings.CONNECTION_PROVIDER;
import static org.hibernate.cfg.JdbcSettings.CONNECTION_PROVIDER_DISABLES_AUTOCOMMIT;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

/**
* @author Vlad Mihalcea
Expand Down Expand Up @@ -75,7 +76,7 @@ private void verifyConnections() {
Connection.class.getMethod( "setAutoCommit", boolean.class ),
connections.get( 0 )
);
assertTrue( "setAutoCommit should never be called", setAutoCommitCalls.isEmpty() );
assertTrue( setAutoCommitCalls.isEmpty(), "setAutoCommit should never be called" );
}
catch (NoSuchMethodException e) {
throw new RuntimeException( e );
Expand Down