HHH-16991 Fix array based id restriction with EnhanceUserType #11306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

beikov merged 2 commits into hibernate:6.6 from beikov:HHH-16991-6.6

Nov 21, 2025

+330 −28

Member

beikov commented Nov 20, 2025 •

edited by hibernate-github-bot bot

Loading

[Please describe here what your change is about]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

https://hibernate.atlassian.net/browse/HHH-16991

hibernate-github-bot bot added the 6.6 label

beikov added 2 commits

November 20, 2025 15:29


          HHH-16991 Fix array based id restriction with EnhanceUserType

441b0db


          Drop container image pre-pull since this is proxied now on CI anyway

d9ea0a2

beikov force-pushed the HHH-16991-6.6 branch from d10f8da to d9ea0a2 Compare

November 20, 2025 14:29

github-advanced-security bot found potential problems

View reviewed changes

hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchAndUserTypeIdCollectionTest.java

+              public class BatchAndUserTypeIdCollectionTest {
+              	@BeforeAll
+              	public void setUp(SessionFactoryScope scope) {

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Child child1' is never read.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchAndUserTypeIdCollectionTest.java

+              	@BeforeAll
+              	public void setUp(SessionFactoryScope scope) {
+              		scope.inTransaction(

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Child child2' is never read.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchAndUserTypeIdCollectionTest.java

+              	@BeforeAll
+              	public void setUp(SessionFactoryScope scope) {
+              		scope.inTransaction(
+              				session -> {

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Child child3' is never read.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchAndUserTypeIdCollectionTest.java

+              	public void setUp(SessionFactoryScope scope) {
+              		scope.inTransaction(
+              				session -> {
+              					for (long i = 1L; i < 11; i++) {

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Child child4' is never read.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchAndUserTypeIdCollectionTest.java

+              		scope.inTransaction(
+              				session -> {
+              					for (long i = 1L; i < 11; i++) {
+              						Parent parent = new Parent( new Parent.ParentId( "parent-" + i ) );

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Child child5' is never read.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchAndUserTypeIdCollectionTest.java

+              					for (long i = 1L; i < 11; i++) {
+              						Parent parent = new Parent( new Parent.ParentId( "parent-" + i ) );
+              						Child child1 = new Child( i * 100L + 1L, parent );
+              						Child child2 = new Child( i * 100L + 2L, parent );

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Child child7' is never read.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchAndUserTypeIdCollectionTest.java

+              						Parent parent = new Parent( new Parent.ParentId( "parent-" + i ) );
+              						Child child1 = new Child( i * 100L + 1L, parent );
+              						Child child2 = new Child( i * 100L + 2L, parent );
+              						Child child3 = new Child( i * 100L + 3L, parent );

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Child child8' is never read.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchAndUserTypeIdCollectionTest.java

+              						Child child1 = new Child( i * 100L + 1L, parent );
+              						Child child2 = new Child( i * 100L + 2L, parent );
+              						Child child3 = new Child( i * 100L + 3L, parent );
+              						Child child4 = new Child( i * 100L + 4L, parent );

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Child child9' is never read.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchAndUserTypeIdCollectionTest.java

+              						Child child2 = new Child( i * 100L + 2L, parent );
+              						Child child3 = new Child( i * 100L + 3L, parent );
+              						Child child4 = new Child( i * 100L + 4L, parent );
+              						Child child5 = new Child( i * 100L + 5L, parent );

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Child child10' is never read.

hibernate-core/src/test/java/org/hibernate/orm/test/batch/BatchAndUserTypeIdCollectionTest.java

+              						Child child3 = new Child( i * 100L + 3L, parent );
+              						Child child4 = new Child( i * 100L + 4L, parent );
+              						Child child5 = new Child( i * 100L + 5L, parent );
+              						Child child6 = new Child( i * 100L + 6L, parent );

Check notice

Code scanning / CodeQL

Unread local variable Note test

Variable 'Child child11' is never read.

beikov force-pushed the HHH-16991-6.6 branch from 676a633 to d9ea0a2 Compare

November 20, 2025 21:37

beikov merged commit 31d75d0 into hibernate:6.6

48 checks passed

beikov deleted the HHH-16991-6.6 branch

November 21, 2025 07:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.6