HHH-13932: Check for non existing query parameter in CriteriaQueryTypeQueryAdapter and throw an exception with the corresponding message #3355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eQueryAdapter and throw an exception with the corresponding message
NathanQingyangXu
approved these changes
Apr 18, 2020
Member
|
Bug already fixed. Adding test in #9341. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: HHH-13932
Issue:
When the user attempts to set non existing query parameter using
Query::setParameteraNullPointerExceptionis thrown. This is due toCriteriaQueryTypeQueryAdapter.explicitParameterInfoMapnot having a key for the parameter, as it was never used in the query.Solution:
Check for non existing query parameter and throw an
IllegalArgumentExceptionwith the corresponding message.